While loop only retrieving one result

Question

UPDATE: Still can't seem to figure it out. If anyone can lend a hand, it would be appreciated ^^.

I am having a problem and I'm not sure where my code is breaking down. I have a 'follow' function where you can follow different registered users. Their userID's of who you followed are stored in an array (follower_array). It's retrieving each member from the array, but of each member that's followed instead of displaying all the content, it's only displaying the 1 latest one from each member.

$broadcastList= "";

if ( $follower_array != "" ) {

  $followArray = explode(",", $follower_array);
  $followCount = count($followArray);   
  $i = 0;
  $broadcastList .= "<table>";

  foreach( $followArray as $key => $value ) {

    $i++;
    $sqlName = mysql_query("
        SELECT username, fullname 
          FROM members 
         WHERE id='$value' 
         LIMIT 1
    ") or die ("error!");

    while ( $row = mysql_fetch_array($sqlName) ) {
      $friendUserName = substr($row["username"],0,12);
    }

    $sqlBroadcast = mysql_query("
        SELECT mem_id, bc, bc_date, device 
          FROM broadcast 
         WHERE mem_id='$value' 
      ORDER BY bc_date ASC 
         LIMIT 50
    ") or die ("error!");

    while ( $bc_row = mysql_fetch_array($sqlBroadcast) ) {
      $mem_id  = $bc_row['mem_id'];
      $bc      = $bc_row['bc'];
      $dev     = $bc_row['device'];
      $bc_date = $bc_row['bc_date'];
      $broadcastList .= "<td><a href='member.php?id=' .$value. ''>
      $friendUserName</a> &bull; $when_bc &bull; Via: $dev <b>$bc</b></td></tr>";
    }
    broadcastList .= "</table>";
  }
}

So, it's retrieving the members entirely, but not more than their single latest "broadcast." Any insight would be appreciated.. thank you!

Programming is not a contest to see how much stuff you can cram into each line. Indent code blocks on a new line (especially if you're going to bother using {}'s) and keep your code properly indented. — riwalk
– riwalk, Commented Jun 30, 2011 at 22:29
..and for everybody else, who thinks differently, there is perl-golf. — Karoly Horvath
– Karoly Horvath, Commented Jun 30, 2011 at 22:31
Just a second.. There's no contest? I was under the assumption that I would get a stackoverflow badge for the longest lines! :). My Apologies, code has been edited to be more friendly. — dystopia
– dystopia, Commented Jun 30, 2011 at 22:35
@x3ro: Edited again. Now that's how it's supposed to look , IMO... — Tomalak
– Tomalak, Commented Jun 30, 2011 at 22:52

trutheality · Accepted Answer · 2011-06-30 22:37:19Z

2

Here's what's happening:

while( $row = some_next_result_function() ){
    $result = $row["thing"];
}

Is going to overwrite $result every time, so you'll only end up with the last result.

You need to make a list and append to it instead.

answered Jun 30, 2011 at 22:37

trutheality

23.5k6 gold badges58 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

dystopia Over a year ago

I had a sinking feeling it was something as simple as that. Thank you!

dystopia Over a year ago

Unfortunately I changed the $row result but still only coming back with 1 result.

trutheality Over a year ago

Well you're deliberately retrieving 1 friendUserName. Are you sure that you have more than one broadcast for that user?

dystopia Over a year ago

Yes, I have dummy data entered in for 10 broadcasts per user.

Yhn · Accepted Answer · 2011-09-02 09:49:06Z

0

I'm gonna take a shot in the dark:

$broadcastList .= "<td><a href='member.php?id=' .$value. ''>
  $friendUserName</a> &bull; $when_bc &bull; Via: $dev <b>$bc</b></td></tr>";

That line pretty much misses a starting "tr" element. Are you sure the content isn't shown simply because of the faulty html markup?

Also:

broadcastList .= "</table>";

You're missing the $ there ;).

I don't know if this fixes it or even helps you; but I sure hope so :). Alternatively; you can also check the HTML source to see if the entries really aren't there (see first remark).

answered Sep 2, 2011 at 9:49

Yhn

2,8252 gold badges15 silver badges10 bronze badges

Collectives™ on Stack Overflow

While loop only retrieving one result

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related