Construct Laravel query using Conditionals

Question

I am trying to create a query based on data sent from a POST request. I got it working when I expect both values in my form to be set, however I would like one of the values to be optional.

In my Controller if I make that call

$year = request()->year;
if(request()->filled('month')){
    $month = sprintf("%02d",request()->month);
}

That works for correctly setting $year and $month, but I run in to issues in my query. This is what my query looks like:

$matches = DB::table('games')
    ->join('clubs', 'games.opposition','=','clubs.id')
    ->join('stadiums', 'games.stadium','=','stadiums.id')
    ->select('date','clubs.name AS opposition','games.home/away','stadiums.name')
    ->whereYear('date',$year)
    ->whereMonth('date',$month)
    ->get();

I want that ->whereMonth statement to only be added if the month value is set in the form, so I tried to surround it with

->when(request()->filled('month'),function ($q) use ($month) {
                return $q->whereMonth('date',$month);
            })

But it's giving me a Undefined variable: month error.

Does anyone have any suggestions? I tried to replace request()->filled('month) with just $month but it gave me the same error.

mrhn · Accepted Answer · 2021-01-03 20:32:29Z

2

It is because you don't set month if it's not there but it should work as the conditions are the same. Wouldn't simplifying it help, doing it all in one statement, instead of setting it beforehand. Then you don't have the problem of having instantiated the property.

->when(request()->filled('month'), function ($q) {
    return $q->whereMonth('date', sprintf("%02d",request()->month));
})

answered Jan 3, 2021 at 20:32

mrhn

19.1k6 gold badges31 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

AndyReifman Over a year ago

Thanks, looks like that fixed it, my syntax was off. I was planning on inlining it once I got a working solution, just wanted to make it clear what exactly I was trying to do.

mrhn Over a year ago

Glad that it helped. You code was on point, thought maybe a bug between revisions or something, just unnecessary to only set it when present when you just can do it in the condition :)

Collectives™ on Stack Overflow

Construct Laravel query using Conditionals

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related