Ruby join array of strings with space between last two elements

Question

In my Ruby 2.7 app I want to join an array of strings to have one string separated by commas. As follows:

[company.name, company.street, company.zipcode, company.city]
=> ["Sanford, Reilly and Schmidt", "Hoffmannstr. 186", "84875", "Gebesee"]

Expected result:

["Sanford, Reilly and Schmidt", "Hoffmannstr. 186", "84875 Gebesee"]

Obviously to have such a result I can put an empty string between company.zipcode and company.city and at the end use .join(', ') method like this:

[company.name, company.street, company.zipcode + ' ' + company.city].join(', ')

But honestly this code is smelly for me, is there any better way to achieve the same result?

Well one way to make it less "smelly" is do not use + to concatenate Strings. Instead use interpolation [company.name, company.street, "#{company.zipcode} #{company.city}"].join(', ') — engineersmnky
– engineersmnky, Commented Jan 6, 2021 at 18:29
The Facets gem has all kinds of interesting methods. Array#conjoin is one of them; it is like join but more powerful. It allows for a second argument (and/or a block): [1,2,3].conjoin(', ', ' and ') # =>"1, 2 and 3" — steenslag
– steenslag, Commented Jan 6, 2021 at 23:50

Timur Shtatland · Accepted Answer · 2021-01-06 18:50:38Z

2

Use two join() calls:

[company.name, company.street, [company.zipcode, company.city].join(' ')].join(', ')

This method is preferred if you have non-blank delimiter on which to join and/or an array argument. In your specific case, the solution by engineersmnky using "#{...} #{...}" is shorter and more clear.

answered Jan 6, 2021 at 18:50

Timur Shtatland

12.8k3 gold badges41 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cary Swoveland · Accepted Answer · 2021-01-07 03:04:42Z

1

arr = [company.name, company.street, company.zipcode, company.city]
  #=> ["Sanford, Reilly and Schmidt", "Hoffmannstr. 186", "84875", "Gebesee"]

arr[0..-3] << "%s %s" % arr[-2, 2]
  #=> ["Sanford, Reilly and Schmidt", "Hoffmannstr. 186", "84875 Gebesee"]

or

arr[0..-3] << arr[-2, 2].join(' ')
  #=> ["Sanford, Reilly and Schmidt", "Hoffmannstr. 186", "84875 Gebesee"]

arr is not mutated.

edited Jan 7, 2021 at 3:04

answered Jan 7, 2021 at 2:31

Cary Swoveland

111k6 gold badges69 silver badges105 bronze badges

Collectives™ on Stack Overflow

Ruby join array of strings with space between last two elements

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related