Local persistent variables in NodeJS WebSocket

Question

I am trying to make persistent variable player for each WebSocket connection like this:

Server.on('request', function(request) {
    const WSCon = request.accept(null, request.origin);
    var player = "none";
    WSCon.on('message', function(message) {
        if (data.action == 0) HandleRoomEnter(player);
        if (data.action == 1) HandleReadyness(player);
    });
});

function HandleRoomEnter(player) {
    player = "Conan";
    console.log("setting: "+player);
}
function HandleReadyness(player) {
    console.log("getting: "+player);
}

However, my output is:

setting: Conan
getting: none

Where is the problem?

Thank you,

pitust · Accepted Answer · 2021-01-09 11:37:43Z

1

This is the correct way of doing this:


Server.on('request', function(request) {
    const WSCon = request.accept(null, request.origin);
    let player = "none";
    function HandleRoomEnter(player) {
        player = "Conan";
        console.log("setting: "+player);
    }
    function HandleReadyness(player) {
        console.log("getting: "+player);
    }

    WSCon.on('message', function(message) {
        if (data.action == 0) HandleRoomEnter(player);
        if (data.action == 1) HandleReadyness(player);
    });
});

Also please use let or const instead of var.

answered Jan 9, 2021 at 11:37

pitust

1098 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lukáš Michalec Over a year ago

Thank you, it is not exactly the correct way, but it help me to find it. I had to remove the "player" parameters from the functions. Instead of "HandleRoomEnter(player)" -> "HandleRoomEnter()". After that, it worked. Thank you

Collectives™ on Stack Overflow

Local persistent variables in NodeJS WebSocket

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related