Why don't nested commands work for discord.py?

Question

I'm trying to make a votekick bot for discord that will mute the person from voice. However, there is a Command not found error when I run the Yes and No functions. So far, this is what I have:

@bot.command(name='votekick')
@commands.has_role('Player')
async def votekick(ctx, user: discord.Member):
    await ctx.send('A votekick against {} has started. Type .yes to vote to mute this person and .no if you don\'t want this person to be muted.'.format(user.name))

    server = ctx.message.guild
    role_id = 805035493573394452

    for member in server.members:
        if role_id in member.roles:
            member.add_roles(get(member.guild.roles, name='able'))

    arole = get(member.guild.roles, name='able')
    yes=0
    no=0
    while len(arole.members) > 0:
        @bot.command(name='yes')
        @commands.has_role('able')
        async def voteyes(ctx):
            author=ctx.message.author
            message=ctx.message
            await bot.delete_message(message)
            await ctx.send('Player {} has voted.'.format(author.display_name))
            author.remove_roles(get(author.guild.roles, name='able'))
            global yes
            yes=yes+1

        @bot.command(name='no')
        @commands.has_role('able')
        async def voteno(ctx):
            author = ctx.message.author
            message = ctx.message
            await bot.delete_message(message)
            await ctx.send('Player {} has voted.'.format(author.display_name))
            author.remove_roles(get(author.guild.roles, name='able'))
            global no
            no = no+1
    if yes > no:
        return None
    else:

        await user.edit(mute=True)

Can anyone tell me what is wrong? Thanks in advance!

It's a reasonable assumption that you can put a command inside another command to make one happen after the other, but unfortunately it doesn't quite work that way. Instead, you'll need to keep track of who was nominated to be kicked in a variable that "outlasts" the function call to votekick, so that then voteno or voteyes (which won't be nested) will know whom to kick. This does unfortunately get a bit complicated, especially if multiple people get nominated to be kicked at the same time. — nanofarad
– nanofarad, Commented Jan 31, 2021 at 3:38

Just for fun · Accepted Answer · 2021-01-31 11:59:03Z

2

There are some things that are wrong here:

Nested commands dont work that way
You need to get the role after each vote to get the new members, as old one will have members constant, it won't update automatically
You probably want to use wait_for here as it will be easier than making several commands
Role ID will not be in member.roles, as it returns a list of Role objects, not role IDs
Bot.delete_message() is not a thing, its Message.delete()
You want to check if yes > no then mute the person, you are doing the opposite

Below is the revised code:

@bot.command(name='votekick')
@commands.has_role('Player')
async def votekick(ctx, user: discord.Member):
    await ctx.send('A votekick against {} has started. Type .yes to vote to mute this person and .no if you don\'t want this person to be muted.'.format(user.name))
    server = ctx.message.guild
    role_id = 805035493573394452
    role = get(member.guild.roles, name='able')
    for i in server.members:
        if role_id in [z.id for z in i.roles]:
            await i.add_roles(role)
    
    role = get(member.guild.roles, name='able')
    yes, no = 0, 0
    while len(role.members) > 0:
        msg = await bot.wait_for("message", check=lambda m: m.guild.id == ctx.guild.id)
        if msg.content == ".yes":
            await msg.delete()
            role = get(member.guild.roles, name='able')
            await msg.author.remove_roles(role)
            await ctx.send(f'Player {msg.author.display_name} has voted.')
            yes += 1
        elif msg.content == ".no":
            await msg.delete()
            role = get(member.guild.roles, name='able')
            await msg.author.remove_roles(role)
            await ctx.send(f'Player {msg.author.display_name} has voted.')
            no += 1
    if yes > no:
        return await user.edit(mute=True)
    return

edited Jan 31, 2021 at 11:59

answered Jan 31, 2021 at 6:59

Just for fun

4,2351 gold badge7 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

sean teo Over a year ago

Thank you! However, there is an extra curly bracket in await ctx.send(f'{Player {msg.author.display_name} has voted.'). Never the less, Thank you so much!

sean teo Over a year ago

Unfortunately, it did not work but thanks a lot still!

Collectives™ on Stack Overflow

Why don't nested commands work for discord.py?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related