setting the onclick value from <script> doesn't work

Question

I have created a button in HTML
<button id = "back_button" type="button" onclick="" value="Home">Go Back</button>
And have the code in the <script> tag
document.getElementById("back_button").onclick = "redirect('" + previous_location + "')"

If I set that manually in the HTML it works fine, but when set via the script it doesn't even run the function. I put a console.log to check and there was no output in the inspect element console or main

Does anyone know what I'm doing wrong or how I can change the value of the location of the button another way?

I think you meant document.getElementById("back_button").onclick = () => redirect('" + previous_location + "') — Pedro Lima
– Pedro Lima, Commented Feb 9, 2021 at 14:16
That doesn't seem to work either Edit; That did work, i just didn't remove the quotes — Mathias
– Mathias, Commented Feb 9, 2021 at 14:18

DDomen · Accepted Answer · 2021-02-09 14:17:50Z

2

When you assign callback from the script, you must provide a function variable, not a string:

document.getElementById("back_button").onclick = redirect(previous_location)

But like this we would assign the result of redirect to the onclick, which should be a function. So create an anonymous function which calls redirect for you:

document.getElementById("back_button").onclick = function() { redirect(previous_location); }
// OR
document.getElementById("back_button").onclick = () => redirect(previous_location);

answered Feb 9, 2021 at 14:17

DDomen

1,8981 gold badge9 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

setting the onclick value from <script> doesn't work

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related