HTML Passing Link information through to javascript method

Question

I am setting up some basic pagination of a table, and I have the following JS function:

function AddPagination() {
    var paginationDiv = document.getElementById("pagination");
    for (i = 0; i < 3; ++i) {
        var page = document.createElement("a");
        page.innerHTML = i + 1;
        page.setAttribute("title", i + 1);
        page.setAttribute("href", "javascript:RenderResultTable(this.innerHTML)");
        paginationDiv.appendChild(page);
    }
}

What I want to do is pass page number clicked on to the RenderResultTable method. I have this number stored as the innerHTML and title for the link element, how can I get this passed through using the above code?

Thanks.

Tyler Crompton · Accepted Answer · 2011-07-12 15:19:59Z

1

Personally, I wouldn't use JavaScript for pagination but if that's the way you want to go, you need to use some string concatenation. I'm not sure what RenderResultTable() does but you can set that line up like this:

page.setAttribute("href", "javascript:RenderResultTable('" + page.innerHTML + "')");

I believe that should do the trick.

EDIT: Shouldn't you be using i++ in your loop instead of ++i? I think what you have right now will give 2 as the first page number. Please correct me if I am wrong.

EDIT: page.innerHTML will need to be escaped by this functions and then unescaped the in the RenderResultTable() function. escape() and unescape(). This is to prevent JavaScript injections and/or accidental bugs.

edited Jul 12, 2011 at 15:19

answered Jul 12, 2011 at 14:27

Tyler Crompton

12.8k15 gold badges69 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sam Dutton Over a year ago

++i should be fine -- there's lots of discussion elsewhere as to why pre or post incrementation is more efficient (or not) in for-loops, depending on the language. Try it out: jsfiddle.net/samdutton/DpmhP

mrk Over a year ago

You might want to add quotes for the arg to RenderResultTable, ie "javascript:RenderResultTable('"+page.innerHTML+"')"); because you may not always have a number as the innerHTML

Darren Young Over a year ago

Perfect thanks. The reason i'm using pagination in Javascript, is that the way the code is, the table is also created in javascript. So I have to write a pagination method also. Thanks again.

Collectives™ on Stack Overflow

HTML Passing Link information through to javascript method

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related