jQuery Defining Custom Functions

Question

I'm trying to a define my own function in jQuery to condense my js file, but I seem to be unable to shorten these two lines. Below is:

*My function

*What it looks like with the function

*What the original code looks like without the function

var AddContent = function(content) {
    $(#log li:last).remove();
    $(#log).append(content);
};


    $('.object').click(function(){
        AddContent('<li>content1</li>');
    });



    $('.object').click(function(){
        $('#log li:last').remove();
        $('#log').append('<li>content1</li>');
    });

What am I doing wrong? Help!

need quotes around your selectors

Greg Guida
– Greg Guida

2011-07-12 17:47:18 +00:00
Commented Jul 12, 2011 at 17:47 — Greg Guida
– Greg Guida, Commented Jul 12, 2011 at 17:47

Soren · Accepted Answer · 2011-07-12 17:48:10Z

2

In your new function AddContent -- you need to put quote around the selectors.

I.e.

var AddContent = function(content) {
    $(#log li:last).remove();
    $(#log).append(content);
};

Should be

var AddContent = function(content) {
    $('#log li:last').remove();
    $('#log').append(content);
};

answered Jul 12, 2011 at 17:48

Soren

14.8k4 gold badges43 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Soren Over a year ago

Also, you may want to tryout the replaceWith function instead of remove/add api.jquery.com/replaceWith

Soren Over a year ago

Your welcome -- You could also just "Accept Answer" instead of leaving a comment :-)

Collectives™ on Stack Overflow

jQuery Defining Custom Functions

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related