Iterating an array of objects using streams

Question

I Have this method that displays an array of objects in a document.

public File generateODSFileWithTemplate(String fileName, Object[][] lignes, File template) throws FileNotFoundException, IOException, JDOMException, TemplateException {

    final Sheet sheet = SpreadSheet.createFromFile(template).getSheet(0);
    sheet.setRowCount(lignes.length);
    
    int column = 0;
    int row = 0;
    //Iterating through the array of Object
    for(Object[] rowObj : lignes){
        for(Object colObj : rowObj){
            sheet.setValueAt(rowObj[column],column,row );
            column++;
        }
        row++;
        column = 0;
    }
    File outFile = new File(fileName);
    sheet.getSpreadSheet().saveAs(outFile);

    return outFile;
}

Is there a way to use streams instead of for loop?

It's inadvisable since you would be using streams to manipulate an existing object outside of the streaming process (which under certain circumstances can have undesirable side effects). And the column increment could create effective final problems. Now I'm not saying it's not possible, but there is nothing wrong with the way you are doing it (assuming it achieves the desired result of course). — WJS
– WJS, Commented Mar 29, 2021 at 22:08
Also, streams should tend to make the process more clearly reflect the problem statement. Like grouping items in a map. I think a stream solution would add unnecessary complexity and tend to muddy the waters so to speak. — WJS
– WJS, Commented Mar 29, 2021 at 22:22

ETO · Accepted Answer · 2021-03-30 12:34:18Z

4

I don't think using Stream API is appropriate in this particular case. Although you could still improve your for loops by using plain old loops instead of the enhanced ones:

for(int row = 0; row < lines.length; row++) {
    for(int col = 0; col < lines[row].length; col++){
        sheet.setValueAt(lines[row][col], col, row);
    }
}

answered Mar 30, 2021 at 12:34

ETO

7,3471 gold badge23 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Iterating an array of objects using streams

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related