Should I use Singleton or Scoped service for making api calls in ASP.NET Core?

Question

I have a class for making API calls. I would like to pass it as dependency and I want to know if it is better to use Singleton or Scoped :

services.AddScoped<IHttpCallService, HttpCallService>();
 or 
services.AddSingleton<IHttpCallService, HttpCallService>();

I know there are differences between Singleton and Scoped in terms of instance creation, but I would like to know which one is more efficient and suitable for this case? And also, if I use Singleton, would it mean that everything would work synchronously?

Maybe this will help you understand better : Dependency injection in ASP.NET Core. — vernou
– vernou, Commented Apr 12, 2021 at 12:15
If you are using an HttpClient... The best approach is use a singleton and make your cals using async/await. HttpClient is designed to work better that way anyways. — Jonathan Alfaro
– Jonathan Alfaro, Commented Apr 12, 2021 at 13:31
@AlexeyRumyantsev this is an asp.net core web Api application. — Navid Rsh
– Navid Rsh, Commented Apr 12, 2021 at 16:02
Regarding "would it mean that everything would work synchronously?": In C# there isn't any kind of queue for requests using the same object or method. If multiple threads are all using the same singleton object, each thread has its own stack and is basically independent. The only thing really shared is any fields on the singleton object. — JamesFaix
– JamesFaix, Commented Apr 12, 2021 at 16:21

David Browne - Microsoft · Accepted Answer · 2021-04-12 16:15:39Z

7

The recommomended pattern is to have your HttpCallService depend on an HttpClient instance, and then register it as a Typed Client with

services.AddHttpClient<HttpCallService>();

This will register HttpCallService as a transient service.

edited Apr 12, 2021 at 16:15

answered Apr 12, 2021 at 12:24

David Browne - Microsoft

90.8k7 gold badges52 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rahul Shukla · Accepted Answer · 2021-05-09 16:51:30Z

0

Best recommendation is to use singleton in this scenario when your dealing with with api calls. Below article explains what is the issue you don't use HttpClient as singleton

services.AddSingleton<IHttpCallService, HttpCallService>();

Read this article for more in depth knowledge on this https://www.stevejgordon.co.uk/httpclient-connection-pooling-in-dotnet-core

answered May 9, 2021 at 16:51

Rahul Shukla

7166 silver badges20 bronze badges

Collectives™ on Stack Overflow

Should I use Singleton or Scoped service for making api calls in ASP.NET Core?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related