Javascript: Passing variable to function breaks function

Question

I am using an onsubmit variable to ensure that the user really means to delete something, however as soon as I put a value in the parenthesis inside the onsubmit it no longer calls the confirm box.

Code:

onClick="confirmSubmit(abc)"

Doesn't work but the following:

onClick="confirmSubmit()"

Does work

Function:

    function confirmSubmit(category)
{
var category = category;
var agree=confirm("Are you sure you wish to DELETE" + category + " and all of its subcategories and photos?");
if (agree)
    return true ;
else
    return false ;
}

confirm() returns a boolean, so you can shorten your return statement by just returning the return value of the confirm. return confirm("Are you sure...");. — user113716
– user113716, Commented Jul 20, 2011 at 19:00

user578895 · Accepted Answer · 2011-07-20 18:57:13Z

5

you need quotes around your abc:

onclick="confirmSubmit('abc')"

Without them you are trying to pass a variable, abc, which doesn't exist and triggers an error

answered Jul 20, 2011 at 18:57

user578895

Sign up to request clarification or add additional context in comments.

5 Comments

George Reith Over a year ago

The problem is these are built by PHP and thus both styles of quotes are already reserved. I have used PHP to convert the variable to a string but to no avail.

user578895 Over a year ago

So escape the quote: echo 'onclick="confirmSubmit(\'abc\')"';

George Reith Over a year ago

Ok but I need this to work with a variable... onClick="confirmSubmit('.$row['Cname'].') is true code

user578895 Over a year ago

'...(\'' . $row['CName'] . '\')'

George Reith Over a year ago

Thanks now the function runs but the variable passed to does not show in the dialog, the variable is definitely contains something because I echo it earlier.

James Montagne · Accepted Answer · 2011-07-20 18:58:18Z

1

onClick="confirmSubmit(abc)" is trying to pass the variable abc, if you intend to pass a string with the value "abc" then do this:

onClick="confirmSubmit('abc')"

answered Jul 20, 2011 at 18:58

James Montagne

78.9k14 gold badges115 silver badges132 bronze badges

Comments

MPS · Accepted Answer · 2011-07-20 21:55:43Z

1

function confirmSubmit(category)  
{  var category = category;

And you've declared "category" twice! Once in the function header and then as a function variable in the next line! What for?

answered Jul 20, 2011 at 21:55

MPS

312 bronze badges

2 Comments

George Reith Over a year ago

That was when it failed at first I was just trying out different things, it has since been removed :), can you see why category would be empty now I've followed cwolves advice? The function runs but there is a blank space in place of the variable category.

MPS Over a year ago

Can't you shorten and simplify the return to... return confirm("Are you sure you wish to DELETE" + category + " and all of its subcategories and photos?")==true;

binarious · Accepted Answer · 2011-07-20 18:58:24Z

0

You're try to pass the variable abc (which does not exist) to the function. Do: onclick="return confirmSubmit('abc');"

answered Jul 20, 2011 at 18:58

binarious

4,58828 silver badges35 bronze badges

Collectives™ on Stack Overflow

Javascript: Passing variable to function breaks function

4 Answers 4

5 Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related