Squirrel appending "sql: " to errors, causing issues when error handling

Question

Golang project: I'm using Squirrel to generate SQL queries, and pgx/stdlib as a Postgres driver. I'm trying to account for a pretty common error, ErrNoRows, based on one of my queries, which is an acceptable error that I want to handle gracefully. The issue is pgx returns the error having text "no rows in result set", whereas Squirrel returns "sql: no rows in result set", so comparing them fails. Same text, just Squirrel is prefixing the error. What is the idiomatic way to handle this? I feel like substringing or replacing the "sql: " out isn't the appropriate way to go.

You should not be comparing the errors' string values, instead you should be comparing the error values themselves, and in the case of wrapped errors you should be using errors.Is and co. — mkopriva
– mkopriva, Commented May 28, 2021 at 18:51
I will not address what you should be looking for. But if you use a tool, and that tool itself adds anything then your code must either accept that addition, handle it or you use another tool. In this case substringing out the undesirable element is an entirely appropriate solution. IMHO: Just accept it and move on. — Belayer
– Belayer, Commented May 28, 2021 at 19:01

dave · Accepted Answer · 2021-05-28 19:50:54Z

2

It's not squirrel prefixing the error, that is what database/sql has for sql.ErrNoRows.

For some reason, pgx does ErrNoRows = errors.New("no rows in result set")

But, since it's exported, you could just do:

pgx.ErrNoRows = sql.ErrNoRows

when your application starts up. Or write a function

func IsErrNoRows(err error) bool {
    return errors.Is(err, sql.ErrNoRows) || errors.Is(err, pgx.ErrNoRows)
}

answered May 28, 2021 at 19:50

dave

65.1k6 gold badges81 silver badges98 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Squirrel appending "sql: " to errors, causing issues when error handling

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related