Foreach is only returning the first value of an array

Question

I don't understand why foreach is only returned the first value from the $even_values array:

Here is the value of $this->sequence array when I print readable on the fibonacci_sequence method:

Array ( [0] => 1 [1] => 2 [2] => 3 [3] => 5 [4] => 8 [5] => 13 [6] => 21 [7] => 34 [8] => 55 [9] => 89 )

So I'm trying to use the return array from fibonacci_sequence method on the even_values method.

Here is the full code:

class fibonacci {

    private $seq_limit;
    private $sequence = array(1,2);
    private $even_values = array();

    public function __construct(int $seq_limit){
    $this->seq_limit= $seq_limit;
    }

    
    public function fibonacci_sequence(){
       for ($i=0; $i<=$this->seq_limit-3; $i++) { 
        $this->sequence[] = $this->sequence[$i] + $this->sequence[$i+1];
       } 
       return $this->sequence;
       //print_r($this->sequence);
    }

    public function even_values(){
        foreach ($this->sequence as $value) {
            if ($value % 2 == 0) {
                $this->even_values[] = $value;
            }
        }
        //return $this->even_values;
       print_r($this->even_values);
    }


 }


 $fibonacci = new fibonacci(10);
 $fibonacci->even_values();

$this->sequence is an array with values 1 and 2. Only one of those two is even, so you only get one of those (2) added to this->even_values, which is output. What is your doubt? — trincot
– trincot, Commented Jun 4, 2021 at 19:05

jibsteroos · Accepted Answer · 2021-06-04 19:23:31Z

1

You seem to have forgotten to invoke the $fibonacci->fibonacci_sequence(); method to change the $sequence array, so do:

$fibonacci = new fibonacci(10);
$fibonacci->fibonacci_sequence();
$fibonacci->even_values();

demo

As suggested by @AbraCadaver, you can also call it from the constructor if it should always be populated:

public function __construct(int $seq_value)
{
    $this->seq_value = $seq_value;
    $this->fibonacci_sequence(); // <---------- ADD HERE
}

edited Jun 4, 2021 at 19:23

answered Jun 4, 2021 at 19:17

jibsteroos

1,4012 gold badges9 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

AbraCadaver Over a year ago

Yes, or call it from the constructor if it should always be populated.

Jonexman Over a year ago

Here is the value of $this->sequence array when I print readable on the fibonacci_sequence method. Array ( [0] => 1 [1] => 2 [2] => 3 [3] => 5 [4] => 8 [5] => 13 [6] => 21 [7] => 34 [8] => 55 [9] => 89 ) So I'm trying to use the return array from the fibonacci_sequence method on the even_values method.

Collectives™ on Stack Overflow

Foreach is only returning the first value of an array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related