Asp.NetWebAPI add related entities

Question

I am trying to add data to related entities. But I think the way I code is really not appropriate. Should I use SharedService instead of Shared Controller.

Here is my Code

     [HttpPost("addtocart")]
     public IActionResult AddToCart([FromBody] AddToCart addToCart)
     {
         _cartService.Add(addToCart.Cart);
         addToCart.Product.CartId = addToCart.Cart.Id;
         _productService.Add(addToCart.Product);
         addToCart.ProductOption.ProductId = addToCart.Product.Id;
         _productOptionService.Add(addToCart.ProductOption);

         return Ok("Added");
     }

Cart.cs

 public class Cart:IEntity
    {
        public int Id   { get; set; }
        public int UserId { get; set; }
        public DateTime CreatedDate { get; set; }
        public virtual ICollection<Product> Products { get; set; }
    }

Product.cs

public class Product:IEntity
    {
        public int Id { get; set; }
       
        public string SerialNumber { get; set; }
        public string StockCode { get; set; }
        public int CartId { get; set; }
        public int Quantity { get; set; }
        public virtual ICollection<ProductOption> ProductOptions { get; set; }
        
        [ForeignKey(nameof(CartId))] 
        public virtual Cart Cart { get; set; }

    }

ProductOption.cs

 public class ProductOption:IEntity
    {
        public int Id { get; set; }
        public int ProductId { get; set; }
        public int OptionId { get; set; }

        
        [ForeignKey(nameof(ProductId))]
        public virtual Product Product { get; set; }

        [ForeignKey(nameof(OptionId))]
        public virtual Option Options { get; set; }

    }

How can I make it better. Thanks...

It is hard to underestand what do you want. If you need to save addToCart items to DB then post AddToCart and Product classes pls. — Serge
– Serge, Commented Jun 14, 2021 at 10:33

Felix · Accepted Answer · 2021-06-14 06:48:16Z

1

For starters, why do you have data handling both in service (where it should be) and in controller? your service should do both. The tutorials usually have a service per model - but in real applications services are related to some business functions. For example here you can have one service (say, cartService) that handles all the actions related to cart.

But now we are moving to the realm of opinion, which should be avoided on Stack Overflow

Also, your post subject is completely unrelated to the post itself (nothing about Entity framework, or cascade, or delete)

answered Jun 14, 2021 at 6:48

Felix

10.2k10 gold badges65 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Muhammed Akın Over a year ago

Thanks for your answer. I am a learner so What you say is really important for me and wanna learn best practise. I made different Services for single responsibility(SOLID). But, I guess I'm wrong

Felix Over a year ago

Single responsibility isn't the same as single model... "Unwrapping" the object in controller and dispatching to different services is breaking encapsulation, which is much worse!

Muhammed Akın Over a year ago

I will consider your advice. Thanks for your time

Muhammed Akın · Accepted Answer · 2021-06-23 06:20:30Z

0

Sending related JSON data to only CartService solved my problem.

{
    "userId": 2,
    "createdDate": "2021-05-24T00:00:00",
    "products": [
        {
            "serialNumber": "000000499",
            "stockCode": "SP150049  ",
            "quantity": 1,
            "productOptions": null
        }
    ]
}

answered Jun 23, 2021 at 6:20

Muhammed Akın

235 bronze badges

Collectives™ on Stack Overflow

Asp.NetWebAPI add related entities

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related