0

I need to run bunch of scripts saved in text. I need to convert them to JavaScript during runtime and it may have some calls to some functions within that class to get some data, like shown below. Basically I need to expose functions of the class to those scripts being run in one of the function of the same class. It works fine as long as I do not make calls to randomNumbers() function and hard code some numbers. I'll appreciate any feedback on this. thank you,

   var config = {
    minX: 1,
    maxX: 10,
    get randomIntFromInterval() {
        return (() =>
            Math.floor(Math.random() * (this.maxX - this.minX + 1) + this.minX)).bind(
                config
            );
    },
};
        
        
        export const executeFns = () => {
            let edit = `
            let a = randomIntFromInterval();
            let b = randomIntFromInterval();
            if (a> b) {
            console.log('a is bigger than b')
            } else if (b>a) {
            console.log('b is bigger than a')
            }
            console.log('a',a );
            console.log('b',b )`;
        
            var f4 = NamedFunction('fancyname', [], edit, config);
            f4();
        };
        
            export function NamedFunction(name, args, body, scope, values) {
                if (typeof args == 'string') {
                    values = scope;
                    scope = body;
                    body = args;
                    args = [];
                }
            
                if (!Array.isArray(scope) || !Array.isArray(values)) {
                    if (typeof scope == 'object') {
                        var keys = Object.keys(scope);
                        values = keys.map(function (p) {
                            return scope[p];
                        });
                        scope = keys;
                    } else {
                        values = [];
                        scope = [];
                    }
                }
                return Function(
                    scope,
                    'function ' +
                        name +
                        '(' +
                        args.join(', ') +
                        ') {\n' +
                        body +
                        '\n}\nreturn ' +
                        name +
                        ';'
                ).apply(null, values);
            }
18
  • new Function takes the body of the function as an argument, the definition wrapper is not a part of the body. Commented Jun 27, 2021 at 19:30
  • I also can't see any reason, why the function in the example should be dynamically created, there's nothing dynamic in that function. Commented Jun 27, 2021 at 19:38
  • randomNumbers is a method of an instance, not a globally available function. Though since it doesn't use any instance properties (or the this keyword), it really shouldn't be a class method; maybe you shouldn't be using a class here at all. Commented Jun 27, 2021 at 19:46
  • Have a look at this code which lets you put arbitrary values in the scope of the new function definition dynamically. Commented Jun 27, 2021 at 19:48
  • @Teemu I would think the const edit is only a simplification in the example code, and assume it's actually dynamically loaded in from files in the real code. Commented Jun 27, 2021 at 19:50

0

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.