Find maximum value in Object - React Hook

Question

I have a state in React that contains this values :

{
   income 1 : 500,
   income 2 : 300,
   income 3 : 1000
}

This state extend, the customer can add or delete rows in the state, so I need to find in a dynamic way the key/value where the value is the higher in the Object.

I tried this, but it retrieve only the first key/value :

export const maxIncome = (userWalletIncomes) => {
    for (const [key, value] of Object.entries(userWalletIncomes)) {
        return `${key} : ${Math.max(value)}`
    }
}

Any idea ?

Michael Bauer · Accepted Answer · 2021-07-15 08:19:32Z

1

The reason why it returns the first value is because you don't have any conditional logic preventing the return from occurring the first time.

To solve this you need to first find the record with the max value and return that and only return at the end.

export const maxIncome = (userWalletIncomes) => {
    let maxValue = 0;
    let maxKey = '';
    for (const [key, value] of Object.entries(userWalletIncomes)) {
        if(value > maxValue) {
          maxValue = value;
          maxKey = key
        }
    }
    return `${maxKey} : ${maxValue}`
}

The above code can be simplified further but it should make it clear that you need to find the max first before returning.

answered Jul 15, 2021 at 8:19

Michael Bauer

4752 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nikhil_chugh · Accepted Answer · 2021-07-15 08:37:18Z

0

Here, you are not providing any condition before returning and you are implementing Math.max on a single value without any comparison.

This solution will work for you

export const maxIncome = (userWalletIncomes) => {
    for (const [key, value] of Object.entries(userWalletIncomes)) {
     if(Math.max.apply(null,Object.values(userWalletIncomes)) === value){
        return `${key} : ${value}`
        }
    }
}

edited Jul 15, 2021 at 8:37

answered Jul 15, 2021 at 8:25

nikhil_chugh

11 bronze badge

1 Comment

user14265379 Over a year ago

Ok, there were no comparison. Thank you for helping me

Yaya · Accepted Answer · 2021-07-15 08:39:43Z

Take a look at this. sandbox https://codesandbox.io/s/elegant-forest-ik420?file=/src/App.js

You can use an for in to loop through an object

 const salaries = {
    income1: 1000,
    income2: 2000,
    income3: 3000
  };


 const getMax = (data) => {
    let valuesList = []; //The list we're gonna push the values to and then get the maximum out of it
    for (const key in data) { //Looping through
      if (data.hasOwnProperty(key)) { //Check if key exists in the object (optional)
        const element = data[key]; //Get the value of that key and assign it to a variable
        valuesList.push(element); //Push that to the array
      }
    }
    const max = Math.max(...valuesList); //Find the maximum value in the array(array will contain only values of the object)
    return max; //Returning it
  };

and here is how you would call it

 getMax(salaries)

Collectives™ on Stack Overflow

Find maximum value in Object - React Hook

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related