How to unit test asp.net mvc base controllers without hitting the database?

Question

I have been using unit testing for controllers with the 'poor man's' dependency injection technique. Each controller inherits from a base controller to query data for the master page. How do I unit test the controller with it inheriting from base controller without hitting the database?

public class HomeController : BaseController
{
    IUserRepository _userRepository;

    public HomeController() : this(new UserRepository()) {

    }

    public HomeController(IUserRepository userRepository) {
        _userRepository = userRepository;
    }
}

public class BaseController : Controller
{
    protected override void Execute(System.Web.Routing.RequestContext requestContext)
    {
        MyDataContext db = new MyDataContext();

        ViewData["masterPageData"] = db.GetSomeData();

        base.Execute(requestContext);
    }
}

can you provide more info, in particular where is the code that "query data for the master page"? — eglasius
– eglasius, Commented Mar 26, 2009 at 0:33
The code will be called from the Execute method in the BaseController during any Action method in the parent controller. — user82334
– user82334, Commented Mar 26, 2009 at 0:35

eglasius · Accepted Answer · 2009-03-26 00:50:14Z

Code would look something like this:

public class HomeController : BaseController
{
    IUserRepository _userRepository;
    public HomeController() : this(new UserRepository()) { }
    public HomeController(IUserRepository userRepository) : base() {
        _userRepository = userRepository;
    }
    public HomeController(IUserRepository userRepository, ISomeRepository someRepository) : base(someRepository) {
        _userRepository = userRepository;
    }
}
public class BaseController : Controller
{
    ISomeRepository _someRepository;
    public BaseController(ISomeRepository someRepository)
    {
        _someRepository = someRepository;
    }
    public BaseController()
    {
        _someRepository = new SomeRepository();
    }
    protected override void Execute(System.Web.Routing.RequestContext requestContext)
    {
        MyDataContext db = new MyDataContext();
        ViewData["masterPageData"] = _someRepository.GetSomeData();
        base.Execute(requestContext);
    }
}

That said, if you use a DI framework, you would only need 1 constructor in each class. So you can see how it starts leaning towards using one :).

Oscar Cabrero · Accepted Answer · 2009-03-26 00:31:58Z

0

maybe by having a interface on your datacontext and have your datacontext injected then implement a mock of the interface that returns you the data without hitting the database

edited Mar 26, 2009 at 0:31

answered Mar 26, 2009 at 0:25

Oscar Cabrero

4,1698 gold badges33 silver badges49 bronze badges

Comments

Hldev Zkran · Accepted Answer · 2009-03-26 01:06:30Z

0

I would say the problem is that your base controller uses different data access approach. What's more, BaseController is hard wired to DataContext and that results in testability problems.

If BaseController needs to get data from database, why not to use repository in it as well? If full-fledged IoC container is not available, you can inject repository dependency in inherited controllers and pass it to the BaseController.

This way it's easy to create a mock for master page data.

edited Mar 26, 2009 at 1:06

answered Mar 26, 2009 at 1:00

Hldev Zkran

214 bronze badges

Collectives™ on Stack Overflow

How to unit test asp.net mvc base controllers without hitting the database?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related