Axios Returning Undefined

Question

I have the following code:

//agent.js
    import axios from 'axios';
    
    axios.defaults.baseURL = 'https://localhost:5001/api';
    
    const requests = {
      createUser: (payload) => {
        axios.post('/users/create', payload);
      },
      getUsers: () => {
        axios.get('/users').then((r) => {
          console.log(r.data); //outputs the json response
          return r.data;
        });
      }
    };
    
    const agent = {
      requests
    };
    
    export default agent;

//reactComponent.js

import agent from './agent';
function Userlist() {
  const users = agent.requests.getUsers();
  console.log(users); //outputs undefined
}

What am I doing wrong as I get an undefined when making the request from my reactComponent.js.

Does this answer your question? Promise returning undefined

ggorlen
– ggorlen

2021-07-26 01:26:54 +00:00
Commented Jul 26, 2021 at 1:26 — ggorlen
– ggorlen, Commented Jul 26, 2021 at 1:26

kennysliding · Accepted Answer · 2021-07-26 01:15:54Z

2

Because you are not returning anything in your getUsers function.

getUsers: () => {
    axios.get('/users').then((r) => {
      console.log(r.data); //outputs the json response
      return r.data;
    });
}

Remove the function bracket and it should work,

getUsers: () => 
    axios.get('/users').then((r) => {
      console.log(r.data); //outputs the json response
      return r.data;
    });

answered Jul 26, 2021 at 1:15

kennysliding

3,0051 gold badge16 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user31529 Over a year ago

now its returns a promise. i thought the then function resolves that issue?

kennysliding Over a year ago

Not really, you will have to resolve the returned promise as well.

ggorlen Over a year ago

@user31529 Once you have a promise, you can never make it synchronous -- all code that depends on it has to be chained off it, either using then or await. The consequence of this is that Userlist has to be made asynchronous too with await, or use then inside of it and chain the code that depends on the users from it (probably ending in a setState call of some sort).

Collectives™ on Stack Overflow

Axios Returning Undefined

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related