Is there a way to combine multiple list comprehensions in Python?

Question

Here's a function in my code:

def get_weights(Last_scan, Peak_shot):
    Est_Succshots = [x*Peak_shot for x in Last_scan.values()]
    Est_error = [np.sqrt(i)/Peak_shot for i in Est_Succshots]
    Is = [1/m for m in Est_error]
    Weights = [i/sum(Is) for i in Is]
    return Weights

I used 4 list comprehensions to do the calculation. I wonder is there a shorter way or a different approach I can perform such calculations? Thanks for the help:)

I would say this is a good case for just using a for loop instead of list comprehensions. There is no reason to be creating a new list at every step when you could just use a for loop and do all the calculations at once while being equally readable. — Loocid
– Loocid, Commented Aug 11, 2021 at 1:16
You can combine all your mapping ops into a single one. Not sure if that's better. — juanpa.arrivillaga
– juanpa.arrivillaga, Commented Aug 11, 2021 at 1:16
not sure you need a second loop here, id go with Is = [1/(np.sqrt(i)/Peak_shot) for i in Est_Succshots] and drop Est_error — Andreas
– Andreas, Commented Aug 11, 2021 at 1:21

bb1 · Accepted Answer · 2021-08-11 01:22:56Z

4

Assuming that Last_scan.values() is a list of numbers and Peak_shot is a number, this seems to be equivalent to

def get_weights(Last_scan, Peak_shot):
    Is =  np.sqrt(Peak_shot/np.array(Last_scan.values()))
    return Is/Is.sum()

answered Aug 11, 2021 at 1:22

bb1

7,9332 gold badges11 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ZR- Over a year ago

Thanks for the answer! Yes Last_scan is a dictionary and Peak_shot is a number. It returns TypeError: unsupported operand type(s) for /: 'int' and 'dict_values'

bb1 Over a year ago

In such case replace Last_scan.values() by list(Last_scan.values()).

Collectives™ on Stack Overflow

Is there a way to combine multiple list comprehensions in Python?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related