File type PHP validation

Question

What I am doing wrong with the code , it always shows 'File types .doc,.docx,.odt and max file size 2mb supported 'even if the file type is .doc format and size is 0kb.

if(($_FILES["file"]["type"] != 'application/octet-stream') ||
            ($_FILES["file"]["type"] != 'application/vnd.oasis.opendocument.text')||
            ($_FILES["file"]["type"] != 'application/msword')||
            ($_FILES["file"]["size"] > 200000))
        {
            //echo $_FILES["file"]["size"];
            //echo $_FILES["file"]["type"];
            $this->assign_values('msg',"File types .doc,.docx,.odt and max file size 2mb supported");
            //echo "Error: " . $_FILES["file"]["error"] . "<br />";
        }

Try removing the components of your if clause until you see a change. — calumbrodie
– calumbrodie, Commented Aug 1, 2011 at 7:57

Peter · Accepted Answer · 2014-06-29 19:56:37Z

4

You need to change the || to && between the file types. Or even better check the type against a list of allowed types:

$allowedTypes = array('application/octet-stream', 'application/vnd.oasis.opendocument.text', 'application/msword');

if(!in_array($_FILES["file"]["type"], $allowedTypes) || $_FILES["file"]["size"] > 200000)
        {
            //echo $_FILES["file"]["size"];
            //echo $_FILES["file"]["type"];
            $this->assign_values('msg',"File types .doc,.docx,.odt and max file size 2mb supported");
            //echo "Error: " . $_FILES["file"]["error"] . "<br />";
        }

edited Jun 29, 2014 at 19:56

answered Aug 1, 2011 at 7:59

Peter

3,9661 gold badge25 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Suraj Hazarika Over a year ago

Oh thanks. Its working now . Can anyone tell me whts going wrong in my code ?

Peter Over a year ago

Well your if statement in written language is somethin like "If type is not A or type is not B or type is not C or size is greater than 20000". But the type can only have one value. So if it is "A" the check for "type is not B" returns true and your if "matches" also it has the allowed type "A".

Johan · Accepted Answer · 2011-08-01 07:59:37Z

0

You are using OR, which means 1 of the parameters you gave has to be true.

Since you are checking the type 3 times on different values, it is bound to always return true and thus trigger the if.

answered Aug 1, 2011 at 7:59

Johan

1,5571 gold badge11 silver badges17 bronze badges

Comments

Sumair Zafar · Accepted Answer · 2011-08-01 09:55:08Z

0

You are using OR( || ) which if any of the one statement is true the code will execute

answered Aug 1, 2011 at 9:55

Sumair Zafar

988 bronze badges

Collectives™ on Stack Overflow

File type PHP validation

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related