Visual Basic 4: Expected Array

Question

I've been trying to do a little project on Visual Basic 4 (I know, old version. But it needs to work with old computers so), and I have this code for a calculator. It's for the equals command:

Private Sub Command12_Click()
    Dim sd As Integer
    Dim operator As Integer
    Dim result As Integer
    Dim Val As String

    If operator = 1 Then
        result = Val(num) + Val(txtOutput.Text)
        txtOutput.Text = result
    ElseIf operator = 2 Then
        result = Val(num) - Val(txtOutput.Text)
        txtOutput.Text = result
    ElseIf operator = 3 Then
        result = Val(num) * Val(txtOutput.Text)
        txtOutput.Text = result
    ElseIf operator = 4 Then
        result = Val(num) / Val(txtOutput.Text)
        txtOutput.Text = result
    ElseIf operator = 5 Then
        result = Val(num) Mod Val(txtOutput.Text)
        txtOutput.Text = result
    ElseIf operator = 6 Then
        result = Val(num) * Val(num)
        txtOutput.Text = result
    End If
End Sub

The problem is, once I run it, it shows this error:
.

I tried searching on the Internet, and the only solution I have found online is to "Close and reopen Visual Basic and hope it works", but it doesn't... Any suggestions?

You have declared Val as string: Dim Val As String. Why?

Steeeve
– Steeeve

2021-08-28 12:42:37 +00:00
Commented Aug 28, 2021 at 12:42 — Steeeve
– Steeeve, Commented Aug 28, 2021 at 12:42

Mark Moulding · Accepted Answer · 2021-08-29 21:36:10Z

5

As others have said, the problem that's directly causing the error is the Dim Val as String statement, but I don't see where anyone has mentioned the reason...

The issue is that by Diming the identifier Val, you've effectively masked the intrinsic Val() function. Later in your original code, when you refer to the identifier, you're doing so using a syntax that requires either an array or a function; since you've Dimed it as a variable, the parser then assumes that it must be an array variable, which it's not - hence the Expected array error.

Simple fix - just delete the Dim Val as String line. The code could be shortened somewhat by moving the txtOutput.Text = result statement outside of the If...End If block, which would be an improvement in both size and clarity (but not performance), but it would otherwise work as is.

answered Aug 29, 2021 at 21:36

Mark Moulding

6393 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

oguz ismail · Accepted Answer · 2021-08-29 07:22:47Z

2

As @Steeeve says, remove the 'Val as String' line, but I suspect that the error is actually appearing because all the lines starting 'result' have two statements on the line and that's confusing VB. You only need

txtOutput.Text = result

once after the If ... End If statement:

Private Sub Command12_Click()
    
    Dim sd As Integer
    Dim operator As Integer
    Dim result As Integer
    
    If operator = 1 Then
      result = Val(num) + Val(txtOutput.Text)
    
    ElseIf operator = 2 Then
      result = Val(num) - Val(txtOutput.Text)
    
    ElseIf operator = 3 Then
      result = Val(num) * Val(txtOutput.Text)
    
    ElseIf operator = 4 Then
      result = Val(num) / Val(txtOutput.Text)
    
    ElseIf operator = 5 Then
      result = Val(num) Mod Val(txtOutput.Text)
    
    ElseIf operator = 6 Then
      result = Val(num) * Val(num)
    
    End If
    
    txtOutput.Text = result
 End Sub

edited Aug 29, 2021 at 7:22

oguz ismail

51.9k16 gold badges64 silver badges83 bronze badges

answered Aug 28, 2021 at 13:58

John Eason

5712 silver badges8 bronze badges

2 Comments

Jim Mack Over a year ago

Not to critique your solution, but where do you see multiple statements on one line? In my browser their code is correctly formatted (if non-optimal)

John Eason Over a year ago

The original posting was edited and reformatted after I posted my answer. Originally the lines just had a space after the 'result' statement and were immediately followed on the same line by the txtOutput.txt lines.

jmoreno · Accepted Answer · 2021-08-29 21:19:39Z

The obvious problem is the redefining Val, but you can also clean things up a bit to make it easier to understand by doing the conversions just once.

Private Sub Command12_Click()
    Dim sd As Integer
    Dim operator As Integer
    Dim result As Integer
   
    Dim vNum = Val(num)
    Dim vOuput = Val(txtOutput.Text)

    If operator = 1 Then
        result = vNum + vOuput
    ElseIf operator = 2 Then
        result = vNum - vOuput
    ElseIf operator = 3 Then
        result = vNum * vOuput
    ElseIf operator = 4 Then
        result = vNum / vOuput
    ElseIf operator = 5 Then
        result = vNum Mod vOuput
    ElseIf operator = 6 Then
        result = vNum * vNum  
    End If
   
    txtOutput.Text = result
End Sub

user11975130 · Accepted Answer · 2021-08-31 05:30:46Z

1

Val is a built-in function which returns a number read from a string.

Example:

value% = Val("abc123") 'returns 123

answered Aug 31, 2021 at 5:30

user11975130

Collectives™ on Stack Overflow

Visual Basic 4: Expected Array

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related