Laravel - local.ERROR: ErrorException: Non-static method Illuminate\Database\Eloquent\Model::update() should not be called statically

Question

I am using Laravel-8 and Maatwebsite-3.1 package for Excel Upload:

public function onRow(Row $row)
{
    $rowIndex = $row->getIndex();
    if($rowIndex >= 1000)
        return; // Not more than 1000 rows at a time

    $row = $row->toArray();
    $employee = Employee::create([
        'first_name'                        => $row[0],
        'other_name'                        => $row[1] ?? '',
        'last_name'                         => $row[2],
        'email'                             => preg_replace('/\s+/', '', strtolower($row[3])),,
        'company_id'                        => Auth::user()->company_id,
        'created_at'                        => date("Y-m-d H:i:s"),
        'created_by'                        => Auth::user()->id,
    ]);

    if (User::where('email', '=', $employee->email)->exists()) {
        $user = User::update([
            'first_name'                        => $employee->first_name,
            'other_name'                        => $employee->other_name ?? '',
            'last_name'                         => $employee->last_name,
            'updated_at'                        => date("Y-m-d H:i:s"),
            'updated_by'                        => Auth::user()->id,
        ]);
     }else{
        $user = User::create([
            'email'                             => $employee->email,
            'username'                          => strtok($row[3], '@'),
            'password'                          => bcrypt("123456"),
            'first_name'                        => $employee->first_name,
            'other_name'                        => $employee->other_name ?? '',
            'last_name'                         => $employee->last_name,
            'created_at'                        => date("Y-m-d H:i:s"),
            'created_by'                        => Auth::user()->id,
        ]);
     }
}

I got this error:

local.ERROR: ErrorException: Non-static method Illuminate\Database\Eloquent\Model::update() should not be called statically

It points at:

$user = User::update([

How do I resolve this?

Thanks

@Collin - Sorry. I have updated my code. This is the error: local.ERROR: ErrorException: Non-static method Illuminate\Database\Eloquent\Model::update() should not be called statically — user11352561
– user11352561, Commented Sep 3, 2021 at 10:26
User::update() is not static. get the user and $user->update(). The error is quite clear I think. How would Laravel know what user to change? — Gert B.
– Gert B., Commented Sep 3, 2021 at 10:26

Yudiz Solutions · Accepted Answer · 2021-09-03 10:52:57Z

0

try this,

$user = User::where('email', '=', $employee->email)->first();
if ($user) {
        $user = $user->update([
            'first_name'                        => $employee->first_name,
            'other_name'                        => $employee->other_name ?? '',
            'last_name'                         => $employee->last_name,
            'updated_at'                        => date("Y-m-d H:i:s"),
            'updated_by'                        => Auth::user()->id,
        ]);
     }

answered Sep 3, 2021 at 10:52

Yudiz Solutions

4,5072 gold badges11 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Phát Nhâm · Accepted Answer · 2021-09-03 10:42:10Z

0

You should use update() on an instance or collection of models. Eg:

$user = User::find($user_id);
$user->update($new_data);

Or if you want to update all records. Use:

User::query()->update($new_data);

answered Sep 3, 2021 at 10:42

Phát Nhâm

114 bronze badges

Comments

bigdevlarry · Accepted Answer · 2021-09-03 11:01:47Z

0

why not use the updateOrCreate method, something like this will work just fine for your scenario

$user = User::updateOrCreate(
[   'email' =>  $employee->email],
[  
    'username'   => strtok($row[3], '@'),
    'password'   => bcrypt("123456"),
    'first_name' => $employee->first_name,
    'other_name' => $employee->other_name ?? '',
    'last_name'  => $employee->last_name,
    'created_at' => date("Y-m-d H:i:s"),
    'created_by' => Auth::user()->id
]);

You can read more about it here

answered Sep 3, 2021 at 11:01

bigdevlarry

2452 silver badges9 bronze badges

Collectives™ on Stack Overflow

Laravel - local.ERROR: ErrorException: Non-static method Illuminate\Database\Eloquent\Model::update() should not be called statically

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related