Undefined Offset Error in PHP code

Question

I am receiving the following error:

Notice: Undefined offset: 1 in /home/content/53/7382753/html/Summer/wootsummer.php on line 101

on my code that is live at http://obsidianpunch.com/Summer

The offending line is $topnow=$top[$countforme]; however $top and $countforme are defined, so I am not sure why this is causing an error. Any suggestions are very welcome.

For context, the snippet where it appears (wootsummer.php) is bellow.

<html>
<body>

<?php

error_reporting(E_ALL);
set_time_limit (0);

$urls=explode("\n", $_POST['url']);
//$proxies=explode("\n", $_POST['proxy']);

$target=$_POST['target'];

$allurls=count($urls);
//$allproxies=count($proxies);

//use the new tool box
require "ToolBoxA4.php";
echo "before loops all ok";

for ( $counter = 0; $counter < $allurls; $counter++) {
//for ( $count = 0; $count <= $allproxies; $count++) {


 $ch = curl_init();
 curl_setopt($ch, CURLOPT_URL,$urls[$counter]);
 curl_setopt($ch, CURLOPT_FOLLOWLOCATION, 1);
 curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
 curl_setopt($ch, CURLOPT_CUSTOMREQUEST,'GET');
 curl_setopt ($ch, CURLOPT_HEADER, 1); 
 curl_exec ($ch); 
 $curl_scraped_page=curl_exec($ch); 

echo "after curl ok";

//call the new function parseA1
$arrOut = parseA1 ($curl_scraped_page);


$curl_scraped_page=strtolower($curl_scraped_page);
$haystack=$curl_scraped_page;
if (strlen(strstr($haystack,$target))>0) {



$FileName = abs(rand(0,100000));
$FileHandle = fopen($FileName, 'w') or die("can't open file");
fwrite($FileHandle, $curl_scraped_page);

echo "after fwrite ok";



$hostname="**************";
$username="************";
$password="******";
$dbname="**********";
$usertable="************";

$con=mysql_connect($hostname,$username, $password) or die ("<html><script language='JavaScript'>alert('Unable to connect to database! Please try again later.'),history.go(-1)</script></html>");
mysql_select_db($dbname ,$con);

$right = explode(",", $arrOut[0]);
$top = explode(",", $arrOut[1]);

for ( $countforme = 0; $countforme <= 5; $countforme++) {

$topnow=$top[$countforme];

$query = "INSERT INTO *********** (time, ad1) VALUES ('$FileName','$topnow')";
mysql_query($query) or die('Error, insert query failed');

echo "after mysql ok";

}

for ( $countforme = 0; $countforme <= 15; $countforme++) {

$rightnow = $right[$countforme];


$query = "INSERT INTO *********** (time, ad1) VALUES ('$FileName','$rightnow')";
mysql_query($query) or die('Error, insert query failed');

}

mysql_close($con);


echo '$FileNameSQL';


fclose($FileHandle);
}
curl_close($ch);

}



?>

</body>
</html>

toolboxA4.php, referenced above, is bellow.

<?php

function strTrim ($strIn, $cutA, $cutB){
    //keeps what is between $cutA and $cutB
    $pieces = explode($cutA, $strIn, 2);
    $str1 = $pieces[1];  //keep everything after cutA 

    $pieces = explode($cutB, $str1, 2);
    $strOut = $pieces[0];  //keep everything before cutB            
    return $strOut;
}

function arrWords ($strIn, $theStart, $theEnd){
    //returns what is between $theStart and $theEnd
    $cutA = $theStart;
    $pieces = explode($cutA, $strIn);
    $pieces[0] = "";  //discard the first piece

    $cutB = $theEnd;
    foreach ($pieces as $key => $value) {
        $arrB = explode($cutB, $value, 2);
        $arrOut[$key] = $arrB[0];  //keep everything before cutB        
    }

    return $arrOut;
}

function arrElems ($strIn, $tag){
    //returns what is between <$tag> and </$tag>
    $cutA = "<$tag>";
    $pieces = explode($cutA, $strIn);
    $pieces[0] = "";  //discard the first piece

    $cutB = "</$tag>";
    foreach ($pieces as $key => $value) {
        $arrB = explode($cutB, $value, 2);
        $arrOut[$key] = $arrB[0];  //keep everything before cutB        
    }

    return $arrOut;
}

function arrElemAB ($strIn, $tagA, $tagB){
    //returns what is between <$tagA><$tagB> and </$tagB></$tagA>
    $cutA = "<$tagA><$tagB>";
    $pieces = explode($cutA, $strIn);
    $pieces[0] = "";  //discard the first piece

    $cutB = "</$tagB></$tagA>";
    foreach ($pieces as $key => $value) {
        $arrB = explode($cutB, $value, 2);
        $arrOut[$key] = $arrB[0];  //keep everything before cutB        
    }

    return $arrOut;
}

function DropTag ($strIn, $tag){
    //drops <$tag> and </$tag>.  $strIn can be a string or an array of strings.  $strOut is same type as $strIn.
    $strA = str_replace("<$tag>", "", $strIn);
    $strOut = str_replace("</$tag>", "", $strA);
    return $strOut;
}

function arrCompress ($arrIn){
    //deletes empty array entries
    if(!empty($arrIn)){
        foreach ($arrIn as $key => $value) {
            if ($value == "") {
                unset($arrIn[$key]);
            }       
        }
        $arrIn = array_values($arrIn);  
    }   
    return $arrIn;  
}

function arrDeDup ($arrIn){
    //changes duplicate array entries to empty string
    if(!empty($arrIn)){
        foreach ($arrIn as $key1 => $value1) {
            foreach ($arrIn as $key2 => $value2) {
                if ($key1 != $key2 and $value1 == $value2) {
                    $arrIn[$key2] = "";
                }   
            }
        }
    }   
    return $arrIn;  
}

function arrToString ($arrIn){
    //turns an array into a string
    $strOut = "";
    if(!empty($arrIn)){
        foreach ($arrIn as $value) {
            $strOut .= "$value<br>";                
        }
    }
    return $strOut; 
}

function arrContains ($arrIn, $strIn){
    //deletes array entries that do not contain $strIn.
    foreach ($arrIn as &$value) {
        if (stripos($value, $strIn) === false) {
            $value = "";
        }       
    }
    return $arrIn;
}

function arrNotContain ($arrIn, $strIn){
    //deletes array entries that contain $strIn.
    foreach ($arrIn as &$value) {
        if (stripos($value, $strIn) !== false) {
            $value = "";
        }       
    }
    return $arrIn;
}

function parseStrA1 ($strToParse){  
    //drop some tags
    $strA = DropTag ($strToParse, "b");

    //split the file into Top and RHS
    $strTOP = strTrim ($strA, "<body", "<div id=rhs_block");
    $strRHS = strTrim ($strA, "<div id=rhs_block", ">See your ad here");

    //get the elements using tags
    $arrTOP = arrElemAB ($strTOP, "span", "cite");
    $arrRHS = arrElems ($strRHS, "cite");  

    //remove empty elements
    $arrTOP = arrCompress ($arrTOP);
    $arrRHS = arrCompress ($arrRHS);

    //output results
    $strA = "TOP<br>" 
        . arrToString ($arrTOP) 
        . "<br><br>RHS<br>"
        . arrToString ($arrRHS);
    return $strA;
}

function parseA1 ($strToParse){ 
    //drop some tags
    $strA = DropTag ($strToParse, "b");

    //split the file into Top and RHS
    $strTOP = strTrim ($strA, "<body", "<div id=rhs_block");
    $strNAT = strTrim ($strA, "<body", "<div id=rhs_block");
    $strRHS = strTrim ($strA, "<div id=rhs_block", ">See your ad here");

    //get the elements using tags
    $arrTOP = arrElemAB ($strTOP, "span", "cite");
    $arrRHS = arrElems ($strRHS, "cite");

    //get the links
    $arrNAT = arrWords ($strNAT, '<a href="http://', '" ');
    $arrNAT = arrNotContain ($arrNAT, "oogle");

    //remove empty and duplicate elements
    $arrTOP = arrCompress ($arrTOP);
    $arrRHS = arrCompress ($arrRHS); 
    $arrNAT = arrDeDup ($arrNAT);
    $arrNAT = arrCompress ($arrNAT);

    //combine arrays into strings, comma separated values
    $arrOut[0] = implode(",", $arrRHS);
    $arrOut[1] = implode(",", $arrTOP);
    $arrOut[2] = implode(",", $arrNAT); 

    return $arrOut; 
}

?>

possible duplicate of Undefined Offet Error in cURL Code

Phil
– Phil

2011-08-08 04:56:16 +00:00
Commented Aug 8, 2011 at 4:56 — Phil
– Phil, Commented Aug 8, 2011 at 4:56
new error, same project-so created a new question @Phil

user586011
– user586011

2011-08-08 04:57:17 +00:00
Commented Aug 8, 2011 at 4:57 — user586011
– user586011, Commented Aug 8, 2011 at 4:57

user517491 · Accepted Answer · 2011-08-08 05:02:55Z

1

The problem is that you are iterating the $top array from 0 to 5, without knowing whether the array actually contains elements at these indexes. So a quick fix would be:

foreach($top as $topnow)
{
    $query = "INSERT INTO *********** (time, ad1) VALUES ('$FileName','$topnow')";
    mysql_query($query) or die('Error, insert query failed');

    echo "after mysql ok";
}

answered Aug 8, 2011 at 5:02

user517491

Sign up to request clarification or add additional context in comments.

Comments

Jordan · Accepted Answer · 2011-08-08 05:06:36Z

1

The following series of code assumes that your explode will have at least 6 items, or else it will fail when attempting to access the array at an index, because that index won't exist.

$top = explode(",", $arrOut[1]);

The above line will need at least 5 commas so that it will create 6 elements

When you loop through like this:

for ( $countforme = 0; $countforme <= 5; $countforme++) {
    $topnow=$top[$countforme];
    ...

When you reach a $countforme value that is greater than the length of $top - 1, it will fail.

Have you considered changing the for loop to be something more traditional, such as:

$top = explode(",", $arrOut[1]);
for ( $countforme = 0; $countforme < count($top); $countforme++) {
    $topnow=$top[$countforme];
    ...

edited Aug 8, 2011 at 5:06

answered Aug 8, 2011 at 4:59

Jordan

32.7k6 gold badges59 silver badges67 bronze badges

2 Comments

Phil Over a year ago

Try count() instead of array_count(). Or even better foreach ($top as $topnow)

user586011 Over a year ago

new error with new code+foreach($top as $topnow) @Phile Parse error: syntax error, unexpected T_FOREACH in /home/content/53/7382753/html/Summer/wootsummer.php on line 66

bumperbox · Accepted Answer · 2011-08-08 04:57:57Z

0

just before here

for ( $countforme = 0; $countforme <= 5; $countforme++) {

can you do

echo count($top);

just to prove that there are <=5 values in that array

answered Aug 8, 2011 at 4:57

bumperbox

10.2k6 gold badges46 silver badges66 bronze badges

Collectives™ on Stack Overflow

Undefined Offset Error in PHP code

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related