Refactor if-else php code

Question

Sorry, noob question. What's the best way to refactor this?

if (is_dir('temp'))
{
  ===== do action A =====
}
else
{
  mkdir("/path/to/my/dir", 0755);
  ===== do action A =====
}

Thanks.

Olaf · Accepted Answer · 2011-08-09 07:19:41Z

8

if (!is_dir('temp'))
{
   mkdir("/path/to/my/dir", 0755);
}
===== do action A =====

answered Aug 9, 2011 at 7:19

Olaf

10.3k8 gold badges41 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tdammers · Accepted Answer · 2011-08-09 07:19:46Z

3

What about:

if (!is_dir('temp'))
{
    mkdir("/path/to/my/dir", 0755);
}
===== do action A =====

answered Aug 9, 2011 at 7:19

tdammers

20.7k1 gold badge41 silver badges57 bronze badges

Kokos · Accepted Answer · 2011-08-09 07:21:08Z

1

Personally, I use this 'shorthand' for if blocks that only contain one line of code.

if(!is_dir('temp'))
    mkdir("/path/to/my/dir", 0755);

answered Aug 9, 2011 at 7:21

Kokos

9,1715 gold badges29 silver badges45 bronze badges

Calum · Accepted Answer · 2011-08-09 07:20:28Z

0

if(!is_dir('temp')){ mkdir("/path/to/my/dir", 0755); }

===== do action A =====

answered Aug 9, 2011 at 7:20

Calum

5,3361 gold badge24 silver badges27 bronze badges