How to separate a common code from implementation specific code?

Question

I have something like this:

switch(type){
    case "CAR":
       return new Car();
    case "BIKE":
       return new Bike();
}

Now, there is a requirement, to add a common API for both to check if input type is valid, only when validateFlag is true.

Can you suggest some design here? What's the best to go with?

I am thinking of something like:

if(flag== true)
  return new Validator();
switch(type){
    case "CAR":
       return new Car();
    case "BIKE":
       return new Bike();
}```

What is the return type of the method? @Turtle seams to think it's a common superclass of Car and Bike, which makes sense, but returning a Validator doesn't make much sense if you can also return a Car or a Bike. — Maurice Perry
– Maurice Perry, Commented Nov 29, 2021 at 9:58
If it's not a type of car or bike, how do you think we should separate this, we can add a if else block while calling this itself, but the idea is to avoid if else's and instead use some design pattern — bhargavi bharu
– bhargavi bharu, Commented Dec 7, 2021 at 4:57

Turtle · Accepted Answer · 2021-11-29 09:09:31Z

1

You might want to use inheritance here. Have a look at the sample code below.

class Vehicle {
    protected boolean mIsValid;
    
    public Vehicle() {}
    
    public boolean isValid() {
        return mIsValid;
    }
}

class Car extends Vehicle {
    public Car() {
        super();
        mIsValid = true;
    }
}

class Bike extends Vehicle {
    public Bike() {
        super();
        mIsValid = false;
    }
}

answered Nov 29, 2021 at 9:09

Turtle

7141 gold badge6 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to separate a common code from implementation specific code?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related