Spring 3.0 multiple @PathVariable's problem

Question

In my application I have to compare 3 products for that in my controller I mapped request as

@RequestMapping(value = "/products/{proId1}Vs{proId2}Vs{proId3}", method = RequestMethod.GET)
public ModelAndView compareThreeProducts(@PathVariable("proId1") int id1, @PathVariable("proId2") int id2, @PathVariable("proId3") int id3)
{
   //someLogic

when hit my url(http://something/products/12Vs13Vs14)

I'm getting http 400 error

I also tried for 2 @pathVariable like

@RequestMapping(value = "/products/{proId1}Vs{proId2}", method = RequestMethod.GET)
public ModelAndView compareTwoProducts(@PathVariable("proId1") int id1, @PathVariable("proId2") int id2)

this is working fine but why i'm facing problem with 3 variables and also there are no errors in server log then how to find what's the bug.

any solution??

Please show us header of methods. Also are you sure that one of your products doesn't have Vs string in it's name? — kurochenko
– kurochenko, Commented Aug 11, 2011 at 15:27
I changed my post as u asked. I'm using Integers not strings — Raju
– Raju, Commented Aug 11, 2011 at 16:21
I can confirm the problem for Spring 4, only using slashes as separators. — Michael Piefel
– Michael Piefel, Commented Jan 9, 2014 at 9:25

oksayt · Accepted Answer · 2011-10-27 08:01:55Z

3

How about explicitly specifying the regex you want each path variable to match, as described here?

@RequestMapping(value = "/products/{proId1:\d+}Vs{proId2:\d+}Vs{proId3:\d+}", method = RequestMethod.GET)

answered Oct 27, 2011 at 8:01

oksayt

4,3651 gold badge25 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sdouglass · Accepted Answer · 2011-08-11 19:29:54Z

1

You could try lumping everything into one path variable then parsing it manually:

@RequestMapping(value = "/products/{compareIdString}", method = RequestMethod.GET)
public ModelAndView compareThreeProducts(@PathVariable("compareIdString") String compareIdString)
{
    // split compareIdString on "Vs"
    // parse each resulting value to an int

This is more of a workaround than a solution, though. You might want to debug in the Spring code as Bozho suggested if you want to try to figure out exactly what's going wrong.

answered Aug 11, 2011 at 19:29

sdouglass

2,41017 silver badges25 bronze badges

Comments

Bozho · Accepted Answer · 2011-08-11 16:51:02Z

0

make sure the problem is not in the response - put a breakpoint in the method and see if it is invoked
check log files for any indications
try using slashes as separator /products/{p1}/{p2}/{p3} or /products/{p1}/vs/{p2}/vs/{p3}

edited Aug 11, 2011 at 16:51

answered Aug 11, 2011 at 16:03

Bozho

599k147 gold badges1.1k silver badges1.2k bronze badges

8 Comments

Raju Over a year ago

I searched all my log files I didn't find any errors.. The only error i'm getting is http status 400(The request sent by the client was syntactically incorrect ().)

Bozho Over a year ago

then try the other two points. And also - could you check with firebug what does the request look like?

Raju Over a year ago

Sorry to say that as our project requirement I have to use 'Vs' must.. any other solution..

Bozho Over a year ago

But try it without Vs, only for the sake of experiment and identifying the issue.

Bozho Over a year ago

then fire a bug in the spring issue tracker, and use slashes (you can have 12/vs/23/vs/34 for example.

|

Collectives™ on Stack Overflow

Spring 3.0 multiple @PathVariable's problem

3 Answers 3

Comments

Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related