PHP / MySQL - update table data with session data

Question

How to update table data with data stored in session?

I have following code but it is not working(INSERTING INTO DB not working exactly). Please not that this is just part of the code. Session value are being saved correctly. I have a problem with saving them though.

If I have made silly mistake - apologies - I'm newby.

    $loggedTime = $_SESSION['loggedtime'];
    $thisUser = $_SESSION['usr'];

    $result = mysql_query("UPDATE 'admin' SET dt = $loggedTime WHERE $thisuser");
    if($result) {
         echo "success"; 
    } else { 
        echo "no success"; 
    }

Never output a fixed string while debugging data base problems, it's utterly useless. Always use mysql_error() to tell you exactly WHY a query failed. — Marc B
– Marc B, Commented Aug 11, 2011 at 14:43
@Marc - can you give ma an example please? Currently my statement is returning 'no success' so something is wrong. — Iladarsda
– Iladarsda, Commented Aug 11, 2011 at 14:49
$res = mysql_query(...) or die(mysql_error()) is the quickest/easiest form. — Marc B
– Marc B, Commented Aug 11, 2011 at 14:51
I did: echo mysql_error()."<br />"; and has returned You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '15:45:32 WHERE usr =' at line 1 — Iladarsda
– Iladarsda, Commented Aug 11, 2011 at 14:52

Jacob · Accepted Answer · 2011-08-11 14:53:32Z

5

"UPDATE `admin` SET `dt` = '$loggedTime' WHERE user = '$thisUser'"

Don't use single quotes around column/table names. Single/double quotes indicate string literals. Use back ticks around table/column names, if you have to (i.e. reserved word). Also, have a look at Bobby Tables. Furthermore, you need a column in the where clause.

edited Aug 11, 2011 at 14:53

answered Aug 11, 2011 at 14:41

Jacob

43.6k6 gold badges81 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Iladarsda Over a year ago

after update I'm getting an error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '15:45:32 WHERE usr =' at line 1

Jacob Over a year ago

@NewUSer typo in variable name. Updated it.

Iladarsda Over a year ago

@cularis - updated, but still an error full code here jsfiddle.net/MrTest/GSAk6

Jacob Over a year ago

You are not using the query provided in the answer. Single quotes around strings are missing.

ajreal · Accepted Answer · 2011-08-11 14:41:42Z

3

UPDATE 'admin'

replace the single quote

UPDATE admin SET ...

Understand lots of people tend to use back-tick to quote the table, column name ... i don't think is necessary

just take a look on the mysql docs
THEY never do that

answered Aug 11, 2011 at 14:41

ajreal

47.4k11 gold badges98 silver badges119 bronze badges

2 Comments

Jacob Over a year ago

I guess it started with phpMyAdmin adding back ticks to every object name, because people tend to use reserved words for tables and columns (desc as a shortcut for description for example). So everybody started putting back ticks around them.

ajreal Over a year ago

rule number one, don't use reserved words (is reserved) for table name, column name :)

JK. · Accepted Answer · 2011-08-11 14:41:29Z

2

Try to explicitly name the column in your WHERE clause and surround variables with single quotes.

"UPDATE `admin` SET dt = '$loggedTime' WHERE user = '$thisuser'"

answered Aug 11, 2011 at 14:41

JK.

5,1261 gold badge29 silver badges26 bronze badges

Comments

user890127 · Accepted Answer · 2011-08-11 14:43:52Z

2

Theres a problem with your SQL query.

UPDATE 'admin' SET dt = $loggedTime WHERE $thisuser

The where clause isn't specifying any condition try:

UPDATE 'admin' SET dt = '$loggedTime' WHERE userField = $thisuser

replacing 'userField' with a relavent field name that you would like to condition for.

answered Aug 11, 2011 at 14:43

user890127

1007 bronze badges

1 Comment

rgin Over a year ago

^ this. and you might want to add curly brackets when you insert variables. ie. "UPDATE admin SET dt = {$loggedTime} WHERE someField = {$thisUser}" you know, just so we cool.

Collectives™ on Stack Overflow

PHP / MySQL - update table data with session data

4 Answers 4

4 Comments

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related