How to escape single quote inside jQuery variable

Question

I have a jQuery with the following code:

id = 100;
name = "O'Keefe";
str = "<button type='button' onclick='selName( "+id+",\""+name+"\")'>Select</button>";

str is loaded into a div.

When I inspect the page it shows:

<button type="button" onclick="selName( 100, "O" Keefe")'>Select</button>

I tried escaping the single quote with

name = name.replace(/'/g, '\'');

But it didn't work.

My code works fine for names without single quote.

Any suggestions on how to deal with names with single quote?

Thanks.

HTML doesn't have any form of escaping inside attributes. So you simply can't have ' inside an attribute if you're using ' as the attribute value delimiter. — Barmar
– Barmar, Commented Dec 18, 2021 at 0:58
I tried it and everything is fine. Can you show how you are loading it into div, pls? — Serge
– Serge, Commented Dec 18, 2021 at 1:11
@Barmar Thank you. After reading your comment about escaping in HTML I did a search and found a solution - replace single quotes with ' It worked. :) — jdias
– jdias, Commented Dec 18, 2021 at 1:21
What has this to do with jQuery? You aren't using it to create that HTML. — gre_gor
– gre_gor, Commented Dec 18, 2021 at 1:38

CertainPerformance · Accepted Answer · 2021-12-18 00:57:04Z

1

Don't use a string for that. Since you say you're using jQuery, you should attach the event listener with jQuery, not with inline events (which have a large number of problems, including this one - tedious quote escaping).

const button = $('<button>Select</button>')
  .on('click', () => selName(id, name))
  .appendTo('selectorOfWhateverYouWantToAppendThisTo');

answered Dec 18, 2021 at 0:57

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jdias Over a year ago

Thank you for the answer. I understand what you are doing, but it would require a significant change on my code. I will keep this in mind for future code. I ended up replacing the single quotes with ' It worked. Thanks.

jdias · Accepted Answer · 2021-12-18 01:26:49Z

0

I found a solution.

id = 100;
name = "O'Keefe";
name = name.replace(/'/g, '&#39;'); //replace single quotes
str = "<button type='button' onclick='selName("+id+",\""+name+"\")'>Select</button>";

When I replace the single quotes with ' the html shows:

<button type="button" onclick="selName( 100, "O'Keefe")">Select</button>

This works. Thanks.

answered Dec 18, 2021 at 1:26

jdias

5,7344 gold badges24 silver badges28 bronze badges

Collectives™ on Stack Overflow

How to escape single quote inside jQuery variable

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related