Find the most common element in a string array GO

Question

i'm fairly new to golang and im having trouble finding the most common string in an array (Windrichting). it should be N but my output gives me W (it always gives me the last string so Windrichting[6]. Can someone help?

this is my code:

package main

import "fmt"

func main() {
    Windrichting := [7]string{"N", "N", "N", "N", "O", "Z", "W"}

windEL, winner := Mostcommon(Windrichting)

fmt.Printf("Mostcommon windrichting: %s\n", windEL)
fmt.Printf("Komt %d x voor\n", winner)
}


func Mostcommon(Windrichting [7]string) (windEL string, winner int) {
    var N int
    var O int
    var Z int
    var W int
    Windrichtingbase := [4]string{"N", "O", "Z", "W"}

for _, v := range Windrichting {
    switch v {
    case Windrichtingbase[0]:
        N++
        if N > winner {
            N = winner
            windEL = "Noord"
        }
    case Windrichtingbase[1]:
        O++
        if O > winner {
            O = winner
            windEL = "Oost"
        }
    case Windrichtingbase[2]:
        Z++
        if Z > winner {
            Z = winner
            windEL = "Zuid"
        }
    case Windrichtingbase[3]:
        W++
        if W > winner {
            W = winner
            windEL = "West"
        }
    }
}
return windEL, winner
}

output

bruceg · Accepted Answer · 2021-12-22 23:50:37Z

1

winner is always 0 and you never update it. then after incrementing your direction variables (N, O, Z and W), you immediately overwrite them with the zero value stored in winner. You need to reverse the order of the assignment.

Like in this change: https://go.dev/play/p/VaJgZcijFdh

Note also, that capitalized variables in Go mean they're exported

answered Dec 22, 2021 at 23:50

bruceg

2,5431 gold badge23 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

phonaputer Over a year ago

Solid answer. Kind of off topic but I would also add that it is probably a good idea to make the Windrichting parameter a slice []string rather than an array [7]string. Unless you expect the input data list will always have a length of 7.

aMike · Accepted Answer · 2021-12-23 03:58:08Z

0

Here's an alternate implementation. It uses a histogram to collect the number of times a word appears. It then steps through the histogram to find the most common word. Nothing is hard-coded.

https://go.dev/play/p/wTFvNaPRP6B

answered Dec 23, 2021 at 3:58

aMike

9476 silver badges15 bronze badges

1 Comment

phonaputer Over a year ago

Had the same thought but it doesn't include the output Dutch text OP wanted. So maybe this plus an "enum" for converting from rune to the Dutch strings? I believe the Dutch text may have been his reason for using the switch instead of this implementation.

Collectives™ on Stack Overflow

Find the most common element in a string array GO

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related