TypeError: Cannot read properties of undefined (reading 'preventDefault') React

Question

Hi I am getting TypeError: Cannot read properties of undefined (reading 'preventDefault') on both my fetches. I have a usEffect that is being used to set the pagination. Which is where the problem seems to be but I'm not sure how I can solve this. When I remove the useEffect the search works but the pagination doesn't so I am a bit confused as to why I am getting the error.

Any help is appreciated.

Thanks

import React, {useState, useEffect} from 'react';
import 'bootstrap/dist/css/bootstrap.min.css';
import { Alert, Col, Row, ListGroup, Container } from 'react-bootstrap';
import { MovieCard } from '../Components/MovieCard';
import { CustomPagination } from '../Components/CustomPagination';


export const Search = () => {
    const [page, setPage] = useState(1)
    const [numOfPages, setNumOfPages] = useState();
    const [query, setQuery] = useState("");
    const [movies, setMovies] = useState([]);
    const [show, setShow] = useState(true);
    // eslint-disable-next-line
    const [sayt, setSayt] = useState([]);
    
    const fetchResults = e => {
        e.preventDefault();
        setQuery(e.target.value);
        fetch(`https://api.themoviedb.org/3/search/movie?api_key=${process.env.REACT_APP_TMDB_KEY}&page=${page}&language=en-US&include_adult=false&query=${e.target.value}`
        )
        .then((res) => res.json())
        .then((data) => {
            if (!data.errors) {
                console.log(data)
                setSayt(data.results);   
            }else{
                <Alert variant="danger">Error</Alert>
            }
        })
    }
    
    const fetchSearch = e => {
        e.preventDefault();
        setQuery(e.target.value);
        fetch(`https://api.themoviedb.org/3/search/movie?api_key=${process.env.REACT_APP_TMDB_KEY}&page=${page}&language=en-US&include_adult=false&query=${e.target.value}`
        )
        .then((res) => res.json())
        .then((data) => {
            if (!data.errors) {
                console.log(data)
                setMovies(data.results);  
                setNumOfPages(data.total_pages); 
            }else{
                <Alert variant="danger">Error</Alert>
            }
        });
        setShow((s) => !s)
    }

    useEffect (()=>{
        fetchSearch();
        fetchResults();
        // eslint-disable-next-line
    }, [page]) 

    const saytShow = e => {
        setShow((s) => !s)
    }
    
    
    return (
        <div>
            <div className="search-container">
            <div className="row height d-flex justify-content-center align-items-center">
                <div className="col-xs-12 col-sm-12 col-md-8 col-lg-8 my-4">
                    <form fetchSearch={fetchSearch} value={query}>
                        <div className="search"> <i className="fa fa-search" onClick={saytShow}></i> 
                            <input 
                                type="text" 
                                className="form-control" 
                                placeholder="Search for a movie..." 
                                onChange={fetchResults}
                                onClick={saytShow}
                            /> 
                            {sayt.length > 0 && (
                                <ListGroup className="sayt" style={{ display: show ? "block" : "none" }}>
                                    {sayt.map(suggestions => (
                                        <ListGroup.Item action type="submit" onClick={fetchSearch} value={suggestions.title}>
                                            {suggestions.title}
                                        </ListGroup.Item>
                                    ))}
                                </ListGroup>
                            )}

                            <button type="submit" onClick={fetchSearch} value={query} className="search-button btn btn-primary">Search</button> 
                        </div>
                    </form>
                    
                </div>
            </div>
            </div>
            <Container fluid className="movie-grid">
                 {movies.length > 0 && (
                   <Row>
                       {movies.map(movieresults => (
                        <Col className="movie-grid" key={movieresults.id}>
                            <MovieCard movieresults={movieresults}/>
                        </Col>
                        ))}
                   </Row>    
                 )}
            </Container>
            <CustomPagination setPage={setPage} numOfPages={setNumOfPages} />

        </div>
        
        
    )
}

there's no need to call e.preventDefault() - its not directly tied to an event. — Daniel A. White
– Daniel A. White, Commented Jan 3, 2022 at 15:40
when i remove that i get TypeError: Cannot read properties of undefined (reading 'target') — Imad
– Imad, Commented Jan 3, 2022 at 15:43
@VitaliyRayets im not sure what you mean could you do an example for me please? — Imad
– Imad, Commented Jan 3, 2022 at 15:54

Vitaliy Rayets · Accepted Answer · 2022-01-03 15:55:03Z

2

When you call fetchResults fetchSearch in useEffect you haven't event object. Just write correct conditions. Example:

const fetchResults = e => {
      e && e.preventDefault() && setQuery(e.target.value);
      fetch(`YOUR_URL?&query=${e ? e.target.value : query}`)
        .then((res) => res.json())
        .then((data) => {
            if (!data.errors) {
                console.log(data)
                setSayt(data.results);   
            }else{
                <Alert variant="danger">Error</Alert>
            }
        })
    }

the same with fetchSearch function

answered Jan 3, 2022 at 15:55

Vitaliy Rayets

2,4041 gold badge8 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Imad Over a year ago

Perfect thank you that fixed it

VSSSP · Accepted Answer · 2022-01-03 15:57:06Z

0

Try change the button type from submit to button.

<button type="button" onClick={fetchSearch} value={query} className="search-button btn btn-primary">Search</button>

This way you don't need to prevent the default function of type submit.

answered Jan 3, 2022 at 15:57

VSSSP

11 bronze badge

Collectives™ on Stack Overflow

TypeError: Cannot read properties of undefined (reading 'preventDefault') React

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related