Firebase Realtime Database overwrites old data while adding new

Question

Hi there i'm facing issue that FB realtime DB deletes old data while inserting a new one here is my code

 String text = reviewText.getText().toString();
                if (text.length() > 15){
                    int rating = (int) ratingBar.getRating();
                    String uuid = firebaseAuth.getCurrentUser().getUid();
                    Map<String, String> data = new HashMap();
                    data.put("rating", String.valueOf(Integer.parseInt(String.valueOf(rating))));
                    data.put("comment", text);
                    DatabaseReference  db = firebaseDatabase.getReferenceFromUrl("dburl").child("attr_reviews").child(placename);
                    db.setValue(uuid).addOnCompleteListener(new OnCompleteListener<Void>() {
                        @Override
                        public void onComplete(@NonNull Task<Void> task) {
                            if(task.isSuccessful()){
                                db.child(uuid).setValue(data).addOnCompleteListener(new OnCompleteListener<Void>() {
                                    @Override
                                    public void onComplete(@NonNull Task<Void> task) {
                                        if (task.isSuccessful()){

                                        }else {
                                            Toast.makeText(getActivity(), R.string.eReviewErrUnkw, Toast.LENGTH_LONG).show();
                                        }
                                    }
                                });
                            }else {
                                Toast.makeText(getActivity(), R.string.eReviewErrUnkw, Toast.LENGTH_LONG).show();
                            }
                        }
                    });

                }else {
                    Toast.makeText(getActivity(), R.string.eReviewErrTxt, Toast.LENGTH_LONG).show();

                }

I have tried to put push() into diffrent positions but still same. DB structure looks like this It should create DB structure like this on image

Edit: Database structure should look like this

enter code here
DB
 └attr_reviews
             └city1
                  └useruuid1
                           └comment: ""
                           └rating: x
                  └useruuid2
                           └....
            └city2
                 └....

It writes data, but not how it's supposed to be, it delete all other childs (other uuids as well with comment and rating) — gmijo47
– gmijo47, Commented Jan 24, 2022 at 17:34
As a temporary fix you could retrieve the previous values before you push and push everything in on the next push. — Alias Cartellano
– Alias Cartellano, Commented Jan 24, 2022 at 17:41

Francesco D'Onorio De Meo · Accepted Answer · 2022-01-25 18:20:13Z

2

In this way you stop at "Sarajevo"

DatabaseReference  db = firebaseDatabase.getReferenceFromUrl("dburl").child("attr_reviews").child(placename);
//Sarajevo
// ==> PUSHING VALUES
                    db.setValue(uuid).addOnCompleteListener(new OnCompleteListener<Void>() { ...

I think you should go down nesting. Something like

DatabaseReference  db = firebaseDatabase.getReferenceFromUrl("dburl").child("attr_reviews").child(placename).child(userid);

answered Jan 25, 2022 at 18:20

Francesco D'Onorio De Meo

1372 gold badges2 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gmijo47 Over a year ago

Thank's on help this is what i needed

Peter Haddad · Accepted Answer · 2022-01-24 18:33:52Z

0

The data in the database is getting overwritten, what you need to do is use push() which would create a random id for you in the database:

db.child(uuid).push().setValue(data).addOnCompleteListener(new OnCompleteListener<Void>() {

This way you will have the following database:

uuid
  random-id1
       comment: "comment"
       rating: 1
  random-id2
       comment: "comment"
       rating: 1

answered Jan 24, 2022 at 18:33

Peter Haddad

81.2k26 gold badges148 silver badges149 bronze badges

5 Comments

gmijo47 Over a year ago

This example above isn't working properly, imgur.com/ovEUXeM data deleted after inserting a new one

Peter Haddad Over a year ago

It's getting deleted because of the first setValue that you are doing. Is uuid equal to Sarajevo?

gmijo47 Over a year ago

Nah, Sarajevo isn't UUID, Sarajevo is city name, like many other, this cities should have child UserUUID, which represents user review and contains Review, and Rating. Sarajevo should contain childs with UUID

Peter Haddad Over a year ago

remove the first setvalue

db.setValue(uuid).addOnCompleteListener(new OnCompleteListener<Void>() {                         @Override                         public void onComplete(@NonNull Task<Void> task) {

it is not needed

gmijo47 Over a year ago

It's needed beacuse user UUID dont exist as child, and it's needed later to check did user gave review

Collectives™ on Stack Overflow

Firebase Realtime Database overwrites old data while adding new

2 Answers 2

1 Comment

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related