How to use basic deleteview

Question

I start use DeleteView of django.views.generic.

However I am still confused about DeleteView

Document says you don't need to do anything in DeleteView apart from UpdateView,CreateView

So,,,,is this correct??

It doesn't delete the item.

in urls.py

path('preaction/<int:pk>/delete', PreActionDeleteView.as_view(),
     name="pre-action-delete"),

in views.py

class PreActionDeleteView(LoginRequiredMixin, DeleteView):
    model = PreAction
    success_url = reverse_lazy("pre-action-list")

    def delete(self, request, *args, **kwargs):
        success_url = self.get_success_url()
        messages_text = "deleted"
        messages.success(self.request, messages_text)
        return HttpResponseRedirect(success_url)

Rustam Garayev · Accepted Answer · 2022-02-12 16:16:16Z

1

Document says you don't need to do anything in DeleteView apart from

Since you are overriding delete() method, you have to delete the specified object manually which in you case is just to call self.object.delete():

def delete(self, request, *args, **kwargs):
    self.object = self.get_object()
    success_url = self.get_success_url()
    self.object.delete()

    messages_text = "deleted"
    messages.success(self.request, messages_text)
    return HttpResponseRedirect(success_url)

To get more information on how things get handled, see this well-structured flow diagram.

answered Feb 12, 2022 at 16:16

Rustam Garayev

2,6921 gold badge11 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

whitebear Over a year ago

Thank you I overrided delete wrongly. It solves my problem

NixonSparrow · Accepted Answer · 2022-02-12 16:22:57Z

1

Don't override delete() method. It's much clearer to do such things in form_valid():

from django.contrib.messages.views import SuccessMessageMixin


class BookDeleteView(SuccessMessageMixin, DeleteView):
    model = PreAction
    success_url = reverse_lazy("pre-action-list")

    def form_valid(self, form):
        data_to_return = super().form_valid(form)
        messages_text = "deleted"
        messages.success(self.request, messages_text)
        return data_to_return

Just in case, you usually need to return super() of the method, that is normally in the View.

Also you don't need to use return HttpResponseRedirect(success_url), because it's standard behaviour of DeleteView to redirect to success_url.

answered Feb 12, 2022 at 16:22

NixonSparrow

6,4281 gold badge8 silver badges18 bronze badges

1 Comment

whitebear Over a year ago

Thank you I wrongly override delete. form_valid is also good practice.

Collectives™ on Stack Overflow

How to use basic deleteview

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related