Problem with retriveing data from my database using JPA

Question

I'am tring to retrieve from my database (using JPA) for a given list of items name their id, my function wich called by my addFunction return just the id of the last item and ignore the rest!

public ArrayList<Integer> getListidItemByItemName()
  {
       try{
       EntityTransaction entityTrans=emm.getTransaction();
       entityTrans.begin();
          for (String val : listItem)  
          {
           System.out.println("my values"+val);
           javax.persistence.Query multipleSelect= em.createQuery("SELECT i.ItemId FROM Item i WHERE i.ItemName IN (:w)" );
           multipleSelect.setParameter("w", val);
           List ItemId =  new LinkedList();
           ItemId= multipleSelect.getResultList();
           listIdItem = new ArrayList(ItemId);
          }    
          entityTrans.commit();
          System.out.println("Id for given item name"+listIdItem);
          return listIdItem;
         }

         catch(Exception e)
        {
           e.printStackTrace();
        }

The result :

INFO: my valuesResponse Time
INFO: my valuesAssigned Group Response Time
INFO: Id for given item name[7]  //the id of the last item in the list

      return listIdItem;
  }

Where is the problem?

UPDATE: I have use the solution of mat and it worked fine

thank you

Mat · Accepted Answer · 2011-08-20 08:37:29Z

1

listIdItem = new ArrayList(ItemId);

This line replaces whatever you had in listIdItem with a new list. If you want to add to the listIdItem list, do something like:

listIdItem.addAll(ItemId);

answered Aug 20, 2011 at 8:37

Mat

208k41 gold badges407 silver badges423 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mat Over a year ago

Move the print inside the loop to see if you are really getting more than one id (print the ItemId list on each iteration).

rym Over a year ago

@ Mat,yes your right when I have printed the item inside the loop I see know that the function works fine ,but the problem in my other funtion wich add those item into the database!

joschi · Accepted Answer · 2011-08-20 08:58:18Z

0

You're overwriting your variable listIdItem in every iteration of the loop with a new ArrayList. So in the end listIdItem will only contain the last iteration's values.

answered Aug 20, 2011 at 8:58

joschi

13.1k4 gold badges46 silver badges51 bronze badges

Collectives™ on Stack Overflow

Problem with retriveing data from my database using JPA

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related