Unable to push the URL with ID in react.js, React Hook useEffect has a missing dependency inside the array

Question

I'm unable to push the id with history.push But if I don't add id then it works fine. I'm using react-router-dom v5

useEffect(() => {
  fetchData();
  if (!userInfo) {
    history.push("/login"); // This portion works
  } else if (successCreate) {
    history.push(`/order/${order.id}`); // This does not work as expected
  }
}, [userInfo, history]);

// Here if I don't use order.id then it works, However I can console the order.id and it displays the id properly. Is there any alternative to do the same thing in react. ? Or how to fix this issue

Faisal Nazik · Accepted Answer · 2022-03-01 10:26:28Z

1

Problem is, React Hook useEffect has a missing dependency inside the array. You are not adding the successCreate in the dependency array, include it then it will work as you are expecting.

Modify your code to :

useEffect(() => {
  fetchData();
  if (!userInfo) {
    history.push("/login"); // This portion works
  } else if (successCreate) {
    history.push(`/order/${order.id}`); // Now this will work as expected
  }
}, [userInfo, history, successCreate]); // Modifed Line

edited Mar 1, 2022 at 10:26

answered Mar 1, 2022 at 10:16

Faisal Nazik

2,9735 gold badges25 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

atropa belladona Over a year ago

Thanks faisal, that's working now.

baggiogiacomo · Accepted Answer · 2022-03-01 10:11:22Z

0

Are you sure that order.id has a value? It could be undefined maybe. Literal string seems to be ok

answered Mar 1, 2022 at 10:11

baggiogiacomo

3363 silver badges15 bronze badges

1 Comment

atropa belladona Over a year ago

Yes i have the id as Integer

Collectives™ on Stack Overflow

Unable to push the URL with ID in react.js, React Hook useEffect has a missing dependency inside the array

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related