Conditional routing in controller not working Node Express

Question

I've built some conditional logic to control access to a subdomain (producer.localhost:3000)

Only users with role 'admin' should be able to access the site, everyone else (with role of 'user') should be redirected to their profile page.

This is the code inside producerController.js :

index = (req, res, next) => {
if ((req.oidc.user['https://localhost:3000.com/roles']).includes("user")){
  res.redirect('http://localhost:3000/user/profile')
} 
else {
  res.render('producer/index')
  };
};

The problem is that it redirects for ALL user roles (rather than just those with ‘user’ as a role)

added to question for you - I will also add something else I tried — nc14
– nc14, Commented Mar 24, 2022 at 16:34
no - I've double checked in the console.log of an admin and it simply has : { 'localhost:3000.com/roles': [ 'admin' ], — nc14
– nc14, Commented Mar 24, 2022 at 16:41
Looks like something weird is going on. Have tried swapping the conditions? Like includes("admin") and else part for users? — DJ Hemath
– DJ Hemath, Commented Mar 24, 2022 at 16:43

user16390425 · Accepted Answer · 2022-03-24 17:54:43Z

1

Doesn't seem like an express issue to me, try something like this


const express = require('express');
const app = require('express');

//Only allows users to continue to route if admin is one of their roles
const adminRoute = (req, res, next) =>{
    if(req.oidc.user['https://localhost:3000.com/roles'].includes('admin'))
        next();
    else
        res.redirect('http://localhost:300/user/profile');
}


//Example use case
//Everything affected by this app.use() (in this case anything underneath it) will only be accessible to users with the admin role
app.use('*', adminRoute)

app.get('/protectedRoute', (req, res) =>{
    res.send('Protected route')
})

//Or you can use it directly inside the route
app.get('/protectedRoute', adminRoute, (req, res) =>{
    res.send('Protected route')
})


app.listen('80', () =>{
    console.log('Listening on port 80')
})

This should work 100% of the time, the only logical conclusion is that your if statement isn't returning the proper value.

In which case you can try using

if(array.indexOf('admin') !== -1)

answered Mar 24, 2022 at 17:54

user16390425

Sign up to request clarification or add additional context in comments.

1 Comment

nc14 Over a year ago

thanks added update to the question

user16390425 · Accepted Answer · 2022-03-24 19:08:45Z

0

The code shouldn't conflict just put them underneath eachother


//Executes this first
app.use((req, res, next) =>{
   doThing();
   next();
})

//Then executes the next route/use
app.use((req, res, next) =>{
   doOtherThing();
   if(something == false) return res.redirect('https://test.com');
   next();
})

//Lastly if next was called in every use statement before this access route
app.get('/someRoute', (req, res) =>{
   res.send('Accessed some route');
}

Not sure if I understand your issue

answered Mar 24, 2022 at 19:08

user16390425

1 Comment

nc14 Over a year ago

I will reword the question to be clearer now I have more info

Collectives™ on Stack Overflow

Conditional routing in controller not working Node Express

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related