Why is my array throwing Out of Range Exception Error?

Question

Why does the following code throw an exception?

for (int i = 0; i <= Items.Length-1; i++)
{
    Console.WriteLine(Items[i,1]);
}

Exception:

System.IndexOutOfRangeException was unhandled
  Message="Index was outside the bounds of the array."
  Source="Es"
  StackTrace:
       at Es.Program.Main(String[] args) in C:\Users\Fero\Documents\Visual Studio 2005\Projects\Es\Es\Program.cs:line 19
       at System.AppDomain._nExecuteAssembly(Assembly assembly, String[] args)
       at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ThreadHelper.ThreadStart()

Declaration of Items:

Function which gets the array of strings:

static string[,] ReadFromFile(string filename, int rowsF)
{
    StreamReader SR;
    string S;
    string[] S_split;

    SR = File.OpenText(filename);
    S = SR.ReadLine();

    string[,] myItems = new String[rowsF, 2];
    int row_number = 0;
    while (S != null)
    {
        S_split = S.Split('"');
        //temp_items[row_number,0] = 
        myItems[row_number,0] = S_split[1];
        myItems[row_number,1] = S_split[2];

        row_number++;
        S = SR.ReadLine();
    }
    SR.Close();
    return myItems;
}

string[,] Items = ReadFromFile(myFile, rowsF);

What does the array declaration look like?

Andrew Hare
– Andrew Hare

2009-04-04 00:01:36 +00:00
Commented Apr 4, 2009 at 0:01 — Andrew Hare
– Andrew Hare, Commented Apr 4, 2009 at 0:01
Can you include the declaration of Items?

Joel
– Joel

2009-04-04 00:01:41 +00:00
Commented Apr 4, 2009 at 0:01 — Joel
– Joel, Commented Apr 4, 2009 at 0:01
I've added some stuff to post

Skuta
– Skuta

2009-04-04 00:05:09 +00:00
Commented Apr 4, 2009 at 0:05 — Skuta
– Skuta, Commented Apr 4, 2009 at 0:05
line 119 is (Console.WriteLine) ?

Aziz
– Aziz

2009-04-04 00:10:49 +00:00
Commented Apr 4, 2009 at 0:10 — Aziz
– Aziz, Commented Apr 4, 2009 at 0:10
If it's short enough, can we see the input file?

Chris Doggett
– Chris Doggett

2009-04-04 00:14:28 +00:00
Commented Apr 4, 2009 at 0:14 — Chris Doggett
– Chris Doggett, Commented Apr 4, 2009 at 0:14

Shog9 · Accepted Answer · 2009-04-04 00:15:15Z

6

You have a straight two-dimensional array. Length gives you the total number of elements in the array, but you're using it to calculate the index for a single dimension. What you want is:

for (int i = 0; i < Items.GetLength(0); i++)
{
    Console.WriteLine(Items[i,1]);
}

edited Apr 4, 2009 at 0:15

answered Apr 4, 2009 at 0:01

Shog9

160k36 gold badges237 silver badges242 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris Doggett · Accepted Answer · 2009-04-04 00:13:04Z

2

Check the length of Items[i]. It appears to be a 2D array, and it's apparently not null, because you'd get a different exception for that, so it probably is just an empty array at Items[i], or only contains one item.

Check for:

Items[i] == null
Items[i].Length > 0

EDIT: Your additional code helped. When you split the string to initialize Items, for the item that's giving you trouble, check what you're storing at index 1. Other than that, I can't see a problem with it.

edited Apr 4, 2009 at 0:13

answered Apr 4, 2009 at 0:02

Chris Doggett

21k4 gold badges63 silver badges87 bronze badges

1 Comment

Skuta Over a year ago

There are two columns in the array.

Raymond Martineau · Accepted Answer · 2009-04-04 00:15:03Z

0

From what I see, there's a small chance one of the lines doesn't follow the format you require. It looks like you're retrieving text based on Quote (") delimitation, and S_split[] might not always have those number of fields.

A blank line at the end of the file, for example, will trigger the exception.

answered Apr 4, 2009 at 0:15

Raymond Martineau

6,0591 gold badge23 silver badges12 bronze badges

Comments

Aziz · Accepted Answer · 2009-04-04 00:12:35Z

0

It's throwing an exception because Items[i].Length is < 2

you need to check that (Items[i].Length >= 2) before trying to access Items[i,1]

edited Apr 4, 2009 at 0:12

answered Apr 4, 2009 at 0:05

Aziz

20.9k8 gold badges68 silver badges71 bronze badges

3 Comments

Skuta Over a year ago

I do not really understand what you mean in here.. What "Item" ??

Aziz Over a year ago

sorry, it's Items (the 2d array you have)

Guffa Over a year ago

The second dimension is large enough, it's the first dimension index that gives the exception. Items.GetLength(0) < Items.Length.

Carra · Accepted Answer · 2009-04-04 00:19:31Z

0

    S_split = S.Split('"');
    //temp_items[row_number,0] = 
    myItems[row_number,0] = S_split[1];
    myItems[row_number,1] = S_split[2];

Are you sure you don't want S_Split[0] & S_Split[1]?

Should see the input file.

answered Apr 4, 2009 at 0:19

Carra

18k8 gold badges66 silver badges75 bronze badges

1 Comment

Skuta Over a year ago

no, I checked the values .. my .dat file contains "something" xxxxxx and I need to get something and xxxxx

Collectives™ on Stack Overflow

Why is my array throwing Out of Range Exception Error?

5 Answers 5

Comments

1 Comment

Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related