Delete multiple rows with PDO and checkboxes using prepared statements?

Question

I have this code,

$q = $dbc -> prepare ("SELECT * FROM tasks ORDER BY date_time LIMIT 0, 15");
$q -> execute();

echo '<form action="/adminpanel?tab=process" method="post">
          <input type="hidden" name="deletetask" />';

while ($todo = $q -> fetch(PDO::FETCH_ASSOC)) {

  echo '<div id="update"><div><strong>' 
           . $todo['date_time'] . '</strong><span>' . $todo['type'] 
           . '</span></div><p>' . $todo['message'] 
           . '</p><input class="checkbox" name="deletetask" value="' 
           . $todo['date_time'] . '" type="checkbox" /></div>';
}

echo '<input type="submit" value="Delete Tasks" /></form>';

Now everything works as expected apart from one thing and I haven't really found any answers on the internet. My while loop will have always more than one row, and will almost always want more than one deleting from it to.

As this script stands the form does work but it will only delete the last checkbox that was clicked. I understand why it is doing this, but I don't understand how to overcome this problem I am using PDO and prepared statements.

The code shoud be DELETE FROM table WHERE id IN(?,?,?...?) — xdazz
– xdazz, Commented Aug 29, 2011 at 8:27
Well - change it! Debug it, rewrite it, decompose it. Are you programmer or what? — Your Common Sense
– Your Common Sense, Commented Aug 29, 2011 at 8:39
@xdazz I didn't copy and paste it, I didn't even try it, I knew it would not work as my form values are displayed in a while loop making the name the same, so in php the $_POST variable would get over ridden with the new value. — carlgcoder
– carlgcoder, Commented Aug 29, 2011 at 8:54

J0HN · Accepted Answer · 2011-08-29 08:56:29Z

3

You are assigning the same name="deletetask" for every checkbox. So, when you submit your form, you receive only last selected deletetask value. So, your mistake is here

<input class="checkbox" name="deletetask" value=

Should be

<input class="checkbox" name="deletetask[]" value=

So you need to rename deletetask to deletetask[] so your checkboxes is sent as an array and than do something like

$todelete = $_POST['deletetask']; 
//or $_GET, if you are submitting form through get. But I would recommend you using POST
$stmt = $pdo->prepare("DELETE FROM table WHERE id = ?");
foreach ($todelete as $id)
    $stmt->execute($id);

answered Aug 29, 2011 at 8:56

J0HN

27.1k5 gold badges59 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

carlgcoder Over a year ago

Thank you will try this now :) finally someone who understood my comment.

rybo111 · Accepted Answer · 2015-07-04 13:59:12Z

1

Here is a simple way to do multiple deletes from your database:

HTML

<input type="checkbox" name="del[]" value="your id">
<input type="checkbox" name="del[]" value="your id">
<input type="checkbox" name="del[]" value="your id">
<input type="checkbox" name="del[]" value="your id">

PHP

$ids = array();
foreach ($_POST['del'] as $pval) {
  $ids[] = (int)$pval;
}
$ids = implode(',',$ids);
$query = $db->prepare("DELETE FROM `pages` WHERE `pages_id` IN ( $ids )");
$query->execute();

edited Jul 4, 2015 at 13:59

rybo111

12.6k4 gold badges64 silver badges74 bronze badges

answered Oct 26, 2013 at 12:03

Victorino

1,66112 silver badges22 bronze badges

Collectives™ on Stack Overflow

Delete multiple rows with PDO and checkboxes using prepared statements?

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related