Nested item in json array is not being deserialized

Question

I am trying to deserialize a json string from an api.

All works except for a nested item - Location which always ends up null

This is the string structure:

[
    {
        "CompanyProfile": "<p>A&amp;B Inc etc...</p>",
        "Address": "56 Test Street, Test, UK",
        "Location": {
            "Latitude": 61.52787,
            "Longitude": -4.32095,
            "Zoom": 13,
            "Icon": null,
            "Format": 0,
            "Api": null,
            "SearchTyped": null
        },
        "Id": 1723,
        "Name": "A&B Inc"
    },
        {
        "CompanyProfile": "<p>B&amp;C Inc etc...</p>",
        "Address": "57 Test Street, Test, UK",
        "Location": {
            "Latitude": 61.2122,
            "Longitude": -4.31111,
            "Zoom": 13,
            "Icon": null,
            "Format": 0,
            "Api": null,
            "SearchTyped": null
        },
        "Id": 1723,
        "Name": "B&C Inc"
    },
]

These are the classes to map to:

public class MemberDto
{
    public int Id { get; set; }
    public string? Name { get; set; }
    public string? CompanyProfile { get; set; }
    public string? Address { get; set; }
    public Location? Location { get; internal set; }
}

public class Location
{
    public decimal Latitude { get; set; }
    public decimal Longitude { get; set; }
}

This is the deserialize code:

var result = await response.Content.ReadAsStringAsync();
var members = JsonConvert.DeserializeObject<List<MemberDto>>(result);

I know I can use ReadFromJsonAsync<List<MemberDto>>() as well but using ReadFromString so I can check the json before deserializing. Anyway the result is exactly the same for ReadFromJsonAsync.

Everything except Location is deserialized successfully

Anyone know what the issue is?

Remove internal: public Location? Location { get; internal set; } ______ public Location? Location { get; set; } — Markus Meyer
– Markus Meyer, Commented May 26, 2022 at 9:20
Make your life easy; take your JSON, paste it into app.quicktype.io and follow the instructions in the comment header of the generated code; paste the generated code back into your app and put the one line of code from the header into the approppriate place in your app code (var members = YourRootObjectName.FromJson(result)) — Caius Jard
– Caius Jard, Commented May 26, 2022 at 9:22
I had this same issue two days ago. It's the caveat where when you auto-add properties to a class (via quick refactoring) the setter is made internal by default. Terrible design choice by MS, because it causes these kinds of issues. (Mine was with asp.net model binding) — JHBonarius
– JHBonarius, Commented May 26, 2022 at 10:04

McNets · Accepted Answer · 2022-05-26 09:30:31Z

4

Remove the internal access modifier in the setter of Location.

public Location? Location { get; set; }

answered May 26, 2022 at 9:30

McNets

10.9k3 gold badges39 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

OfirD Over a year ago

To add upon the answer: In general, for the deserialization to work, the setter should be public. So any non-public modifier, like internal, protected, private should be removed.

Collectives™ on Stack Overflow

Nested item in json array is not being deserialized

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related