Codeigniter multiple controllers vs many methods?

Question

I have a site that has a lot of pages that lye at the root (ex. /contact, /about, /home, /faq, /privacy, /tos, etc.). My question is should these all be separate controllers or one controller with many methods (ex. contact, about, index within a main.php controller )?

UPDATE: I just realized that methods that are within the default controller don't show in the url without the default controller (ie. main/contact wont automatically route to /contact if main is the default controller ). So you would need to go into routes and override each page.

Chris Schmitz · Accepted Answer · 2011-08-30 05:36:08Z

4

If all of these are just pages, I would recommend putting them into a single controller. I usually end up putting static pages like this into a 'pages' controller and putting in routes for each static page to bypass the '/pages' in my URLs.

answered Aug 30, 2011 at 5:36

Chris Schmitz

8,2876 gold badges36 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

ThomasReggi Over a year ago

I would love a way to do the routing automatically. :(

Chris Schmitz Over a year ago

The only way I've found for getting the routing automatically is to use a route like $route['(:any)'] = 'pages/$1'; but then I have to declare routes for all of my controllers... I never really do this unless I have way more static pages than controllers.

jondavidjohn Over a year ago

@ThomasReggi ... Why? it will take 5 minutes to write your routes for these pages, and then you're done...

fatnjazzy · Accepted Answer · 2011-08-30 05:40:46Z

If they are share the same functionality, so they should be in the same controller.
for example, if all of them are using the same model to take content from, so, one controller can easily handle it.
Why in one controller? because you always want to reuse your code.

   class someController{
    function cotact(){
        print $this->getContentFromModel(1);

    }

    function about(){
        print $this->getContentFromModel(2);
    }

    function home(){
        print $this->getContentFromModel(3);
    }

    private function getContentFromModel($id){
        return $this->someContentModel->getContentById($id);
    } 
}

(instead of print, you should use load a view)

See in my example how all of the function are using the same getContentFromModel function to share the same functionality.

but this is one case only, there could be ther cases that my example can be bad for...

Hezuo · Accepted Answer · 2011-08-30 08:26:03Z

in application/config/routes.php

$route['contact'] = "mainController/contact";
$route['about'] = "mainController/about";
$route['home'] = "mainController/home";
$route['faq'] = "mainController/faq";
$route['privacy'] = "mainController/privacy";

and you should add all of these methods within the mainController.php

You can also save the content of the pages in your database, and them query it. For instance, you can send the url as the keyword to identify the page content

   $route['contact'] = "mainController/getContent/contact";
    $route['about'] = "mainController/getContent/about";
    $route['home'] = "mainController/getContent/home";
    $route['faq'] = "mainController/getContent/faq";
    $route['privacy'] = "mainController/getContent/privacy";

in this case you only have to create one method named "getContent" in the controller "mainController" and this method will look something like this:

class mainController extends CI_Controller
{
public function getContent($param)
{
    $query = $this->db->get_where('mytable', array('pageName' => $param));
//  then get the result and print it in  a view
    }    
    }

Hope this works for you

Dmitry Samuylov · Accepted Answer · 2011-08-30 05:36:42Z

1

The page names you listed should probably be different methods inside your main controller. When you have other functionality that is related to another specific entity, like user, you can create another controller for the user entity and have different methods to display the user, update the user, register the user. But its all really a tool for you to organize your application in a way that makes sense for your domain and your domain model.

answered Aug 30, 2011 at 5:36

Dmitry Samuylov

1,5622 gold badges14 silver badges38 bronze badges

Comments

Casey Flynn · Accepted Answer · 2011-10-31 16:09:53Z

1

I've written a blog post about organizing CodeIgniter controller methods that might be helpful to you. Check it out here: http://caseyflynn.com/2011/10/26/codeigniter-php-framework-how-to-organize-controllers-to-achieve-dry-principles/

answered Oct 31, 2011 at 16:09

Casey Flynn

14.1k26 gold badges109 silver badges197 bronze badges

Collectives™ on Stack Overflow

Codeigniter multiple controllers vs many methods?

5 Answers 5

3 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related