Bash backup script

Question

I am trying to make a bash script to backup my sevrer, however it is creating empty tar archive and empty sql files and I don't know why. Can anyone see the problems here?

#!/bin/bash
SERVER_DIR="/var/www/vhosts/site.org"
DATE=$(date +"%d-%m-%Y")
BACKUP_DIR="/backups/$DATE"
NAME="full-$DATE"

MYSQLUSER="admin"
MYSQLPASS="pass"
MYSQLDUMP="$(which mysqldump)"
GZIP="$(which gzip)"

mkdir -p $BACKUP_DIR
tar -zcvf $BACKUP_DIR/$NAME.tar.gz $SERVER_DIR
$MYSQLDUMP -u $MYSQLUSER -p$MYSQLPASS --all-databases | $GZIP -9 > $BACKUP_DIR/$NAME.sql
find /backup/ -mtime +31 -exec rm -rf {} \;

Have you tried outputting your defined variables to see if they are alright? and use their values to run the backup commands manually (Replaced by values) ? — AbiusX
– AbiusX, Commented Sep 2, 2011 at 0:39
and can you echo $BACKUP_DIR/$NAME to make sure it is actually what you want it to be? — Jonathon Reinhart
– Jonathon Reinhart, Commented Sep 2, 2011 at 0:40
Put set -xv at the top of your script to help debug it. This will print out each line that will be executed, and then the line with the various variable values filled in. That will help verify your assumptions. You should also test the status of various commands. For example, check $? after the tar command to make sure it executed correctly. — David W.
– David W., Commented Sep 2, 2011 at 3:05

gbp · Accepted Answer · 2011-09-02 00:42:07Z

2

I think you are just missing a -c on the gzip line, try:

$MYSQLDUMP -u $MYSQLUSER -p$MYSQLPASS --all-databases | $GZIP -c9 > $BACKUP_DIR/$NAME.sql.gz

answered Sep 2, 2011 at 0:42

gbp

462 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

shellter Over a year ago

Welcome @gbp. I agree with you analysis. Good luck.

Leon · Accepted Answer · 2011-09-02 03:26:16Z

0

Are you sure you have right permission to access SERVER_DIR="/var/www/vhosts/site.org", when you run you script.

answered Sep 2, 2011 at 3:26

Leon

2,9045 gold badges22 silver badges32 bronze badges

Comments

tripleee · Accepted Answer · 2011-09-02 08:31:04Z

0

You are creating in /backups but removing old backups from /backup. That hardly matters to the end result, but you will be running out of disk in a few months.

I'm not sure it's useful to have the date in both the directory name and the file names, but that's obviously up to you.

The SQL file name should perhaps have a .gz suffix?

It's hardly useful to put MYSQLDUMP and GZIP in a variable using which; if they can be found on the PATH, the shell will find them as well; or rather, if the shell can't find something, neither can which.

answered Sep 2, 2011 at 8:31

tripleee

192k37 gold badges318 silver badges369 bronze badges

Collectives™ on Stack Overflow

Bash backup script

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related