PHP else Statement

Question

The first part of this code works fine, I just can't seem to get the else statment working for when if ($row[password] == $password_hash) is false. I'm sure I only have a small error somewhere but just can't seem to find it.

list ($sessionname) = checkuser();
if (isset($_POST['save'])){

connect();

$currentpass = sha1($_POST['password']);
$newpass = sha1($_POST['password1']);

$sql = "SELECT password FROM members WHERE username = '$sessionname'";
    $result=mysql_query($sql);
    $row = mysql_fetch_array($result);

        if ($row['password'] == $currentpass)

    $query = mysql_query("UPDATE members SET password = '$newpass' WHERE username = '$_SESSION[username]'");
            $updated = "Your password has been updated";
               print_r($row);
        }else{
    $a = "Passwords do not match";
    return $b;
        }
}

What error, if any do you get? Also, echo out your SQL statements and display MySQL errors. — Michael
– Michael, Commented Sep 4, 2011 at 16:42
You must get at least one "undefined index" notice. If you don't, you need to configure your PHP installation to display errors. — Álvaro González
– Álvaro González, Commented Sep 4, 2011 at 16:44
If you start to indent your code correctly, you will notice your problem pretty fast. As @Herbert stated in his answer, you are missing the opening curly brace. — FrankS
– FrankS, Commented Sep 4, 2011 at 20:50

Herbert · Accepted Answer · 2011-09-04 17:58:38Z

2

You're missing an opening curly brace after the if statement.

if ($row['password'] == $currentpass) {
    $query = mysql_query("UPDATE members SET password = '$newpass' WHERE username = '$_SESSION[username]'");
    $updated = "Your password has been updated";
    print_r($row);
}else{
    $a = "Passwords do not match";
    return $b;
}

Notice the { after if ($row['password'] == $currentpass)

Without the brace (and no error reporting) it's skipping the query and showing the string “Your password has been updated”. That’s why the password doesn’t change in the database and why nothing else seems to work.

By the way:

ini_set('display_errors',1); 
error_reporting(E_ALL);

will turn on error reporting

edited Sep 4, 2011 at 17:58

answered Sep 4, 2011 at 17:39

Herbert

5,7983 gold badges28 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

John Over a year ago

thanks works perfectly. i noticed around 20mins after posting this.

NullUserException · Accepted Answer · 2011-09-04 16:56:11Z

2

Make sure MySQL is returning a result set, by using print_r($row); to debug code.

if ($row['password'] == $password_hash){

Hint: You should use quotes around string keys. If you leave out the quotes, PHP thinks it's a constant.

Read: "why is $foo[bar] wrong".

edited Sep 4, 2011 at 16:56

NullUserException

85.8k31 gold badges212 silver badges239 bronze badges

answered Sep 4, 2011 at 16:41

Rok Kralj

49k10 gold badges75 silver badges80 bronze badges

15 Comments

Rok Kralj Over a year ago

PHP cares, believe me. It was just a friendly hint, not a solution. The real soluton is one below.

str Over a year ago

@NullUserException Just because it works does not mean you should use it that way. It WILL raise an error and it is NOT recommended (documentation).

Rok Kralj Over a year ago

@NullUserException: I never said it was. I'm saying this third time in the row. Please read more carefully. Also thanks for providing a link into my answer.

Lightness Races in Orbit Over a year ago

@Rok: Then this should have been a comment. It is not an answer.

Lightness Races in Orbit Over a year ago

The OP said no matter what i input it always returns "your password has been updated"; there is a resultset being returned.

|

altschuler · Accepted Answer · 2011-09-04 16:49:52Z

1

Your question is not very clear. What happens when you run the code? Did you try checking what both $password_hash and $row[password] are just before the conditional?

I'm pretty sure the problem does not lie in the missing quotes, I just tested it and it works fine, but they should be there anyway.

answered Sep 4, 2011 at 16:49

altschuler

3,9423 gold badges32 silver badges58 bronze badges

3 Comments

John Over a year ago

i've added the quotes but issue is still the same.

John Over a year ago

it just always does the if statement and whether they == the same or not. And i always get the "Your password has been updated" instead of $a "passwords do not match

Lightness Races in Orbit Over a year ago

@John: No, that is not possible.

Collectives™ on Stack Overflow

PHP else Statement

3 Answers 3

1 Comment

15 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

15 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related