Using multiple forEach chained into each other and iterating over a single array, Need an equivalent method to handle the same without forEach looping

Question

My array contains multiple arrays and to access the objects, I have used multiple forEach. How do I handle using multiple foreach loops? Kindly suggest an equivalent method to avoid this chaining. See the below snippet and suggest a better solution to optimize my code.

var v = [
    {
        "company_name": "Apple",
        "company_code": "AP",
        "states": [
            {
                "state_name": "California",
                "state_code": "CA",
                "locations": [
                    {
                        "location_name": "USA - New York",
                        "location_code": "US - NY"
                    },
          {
                        "location_name": "USA - San Francisco",
                        "location_code": "US - SF"
                    }
                ]
            },
        {
                "state_name": "Rajasthan",
                "state_code": "RJ",
                "locations": [
                    {
                        "location_name": "Udaipur",
                        "location_code": "UDR"
                    },
          {
                        "location_name": "Jaipur",
                        "location_code": "JP"
                    }
                ]
            }
        ]
    }
]  
 
var AllData=[]

for (let i = 0; i < v.length; i++) {
  const data = v[i];
  //console.log(data);

    data.states.forEach((state) => {
      state.locations.forEach((location) => {
        const ELEMENT_DATA = {
          companyname: data.company_name,
          statename: state.state_name,
          locationname: location.location_name,
        };
        AllData.push(ELEMENT_DATA);
      });
    });
  
}
console.log(AllData);

What´s the problem with your code?

Paulo Barbosa
– Paulo Barbosa

2022-07-22 12:56:23 +00:00
Commented Jul 22, 2022 at 12:56 — Paulo Barbosa
– Paulo Barbosa, Commented Jul 22, 2022 at 12:56

Askirkela · Accepted Answer · 2022-07-22 13:10:20Z

Not really an optimisation, more of a readability improvement:

const arr = v.map(data =>
  data.states.map(state =>
    state.locations.map(location =>
      ({
        companyname: data.company_name,
        statename: state.state_name,
        locationname: location.location_name
      })
    )
  )
);

Check the following snippet to see if the output is the same.

var v = [{
  "company_name": "Apple",
  "company_code": "AP",
  "states": [{
      "state_name": "California",
      "state_code": "CA",
      "locations": [{
          "location_name": "USA - New York",
          "location_code": "US - NY"
        },
        {
          "location_name": "USA - San Francisco",
          "location_code": "US - SF"
        }
      ]
    },
    {
      "state_name": "Rajasthan",
      "state_code": "RJ",
      "locations": [{
          "location_name": "Udaipur",
          "location_code": "UDR"
        },
        {
          "location_name": "Jaipur",
          "location_code": "JP"
        }
      ]
    }
  ]
}]

const arr = v.map(data =>
  data.states.map(state =>
    state.locations.map(location =>
      ({
        companyname: data.company_name,
        statename: state.state_name,
        locationname: location.location_name
      })
    )
  )
);
console.log(arr)

This is basically your code, looping on each of the properties, it is just more easy to read.

Collectives™ on Stack Overflow

Using multiple forEach chained into each other and iterating over a single array, Need an equivalent method to handle the same without forEach looping

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related