php str_replace used in a loop with mail function

Question

I have an html email message assigned to a variable before it is used in a loop, then in the loop I try to use str_replace to insert custom values into hooks. So in the below example I have an {email} hook which I'm trying to replace with the recipient's email address. My problem is that when I output $message_final to the browser the str_replace function seems to have done the job. But when I send the email out, all the emails are still left with the {email} hook, and it appears that str_replace hasn't worked. Any ideas what i'm missing here? Thanks.

$message = "HTML email message here";

while ($r = mysql_fetch_array($emails_list)) {
    $email =  $r["email"];
    $message_final = "";

    if(!empty($email)) {
        //Replace hook with something new like an email address
        $message_final = str_replace('{email}', $email, $message);
        mail($email, $subject, $message_final, $headers); 
    }
}

Can you post a portion of the actual $message that contains the hooks? — Evan Mulawski
– Evan Mulawski, Commented Sep 5, 2011 at 14:55
Hmm.. the code you posted here looks all right.. Can you post your 'real' code (including the working var_dump() you used to see the message in your browser)? — Rijk
– Rijk, Commented Sep 5, 2011 at 14:57

genesis · Accepted Answer · 2011-09-05 14:41:39Z

1

You've got no {email} string in your $message that could be replaced

answered Sep 5, 2011 at 14:41

genesis

51.1k20 gold badges99 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

lemon Over a year ago

the HTML string is too long to post here, but it's in the variable $message

Evan Mulawski Over a year ago

I'm pretty sure the OP's actual $message has them.

Evan Mulawski Over a year ago

I have just tested a general string replace using an e-mail address and your hook, and it works fine.

genesis Over a year ago

@EvanMulawski: yes, me either

xdazz Over a year ago

I think the OP will find the problem via debugging.

Sebastian Nowak · Accepted Answer · 2011-09-05 14:55:21Z

1

Your code is valid and works flawlessly. The problem lies somewhere else.

There are few things you might want to check:

str_replace is case sensitive, are you sure it's {email} and not {EMAIL}?
does $message contains valid message? try printing it out the browser, open it's source code so you can see additional html tags parsed by browser and check whether it's correct

By the way - you should consider using mysql_fetch_assoc instead of mysql_fetch_array. The method you're using by default combines arrays created by mysql_fetch_row and mysql_fetch_assoc into one, so it takes 2 times more space

answered Sep 5, 2011 at 14:55

Sebastian Nowak

5,7179 gold badges71 silver badges111 bronze badges

Comments

lemon · Accepted Answer · 2011-09-06 08:07:36Z

0

Ahhhhh! Palm to face!! It was something completely different causing the issue. In my mail header I had the message attached there, and I was calling str_replace in the wrong bit of the code. Thanks for all your replies guys :)

answered Sep 6, 2011 at 8:07

lemon

6051 gold badge8 silver badges21 bronze badges

Collectives™ on Stack Overflow

php str_replace used in a loop with mail function

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related