Generic HashMap

Question

I have one method, check which has two hashmaps as parameters. Keys of these maps is a String and value is String or Arraylist.

Which is the better solution:

public static boolean check(HashMap<String, ?> map1, HashMap<String, ?> map2) {
    for ( entry <String, ? > entry : map1.entryset()) {
        ...
    }
}

or

public static <V> boolean check(HashMap<String, V> map1, HashMap<String, V> map2) {
    for ( entry <String, V > entry : map1.entryset()) {
        ...
    }    
}

and why?

And can you also give me some more information about the difference between these two solutions?

Cameron Skinner · Accepted Answer · 2011-09-11 20:17:59Z

5

In the first, the ? coul dbe anything. One could be <String, String> the other could be <String, Double>. In the second option they must be the same.

Now the first is acceptable as long as you have the ability to convert them so they're comparable. For example, you could do .toString() on both values to compare. But personally, I would prefer the second as it allows me to have more control over what's going on, and gives me compile time checking of types.

edited Sep 11, 2011 at 20:17

Cameron Skinner

55.2k3 gold badges70 silver badges86 bronze badges

answered Sep 11, 2011 at 20:03

corsiKa

82.8k26 gold badges162 silver badges210 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Oliver Charlesworth · Accepted Answer · 2011-09-11 20:04:33Z

0

The second one enforces at compile-time that the two maps are parameterised the same as each other. It also allows you do something useful with the maps, such as inserting non-null elements into them (this isn't possible with wildcards).

answered Sep 11, 2011 at 20:04

Oliver Charlesworth

274k34 gold badges591 silver badges687 bronze badges

Collectives™ on Stack Overflow

Generic HashMap

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related