PHP switch() statement

Question

Is this good practise ... ie, grouping the default case with another?

    switch ($cond){
            case 1:
                ...;
                break;
            case 2:
                ...;
                break;
            case 3:
            default:
                ...;
                break;
        }

A comment to indicate that falling-through is INTENDED would be good, but otherwise there's nothing wrong with it. — Marc B
– Marc B, Commented Sep 12, 2011 at 16:24

Chuck Callebs · Accepted Answer · 2011-09-12 16:16:24Z

3

It makes perfect sense to do it that way.

Also, @Ian is correct, but in a limited scope. If you wanted additional functionality applied to case 3 you would leave it the way it is. As long as you don't break, it will go on to the next case.

answered Sep 12, 2011 at 16:16

Chuck Callebs

16.4k8 gold badges59 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ian Oxley · Accepted Answer · 2011-09-12 16:14:29Z

1

It kind of makes case 3 redundant though, so I'd remove it and just leave it as default

answered Sep 12, 2011 at 16:14

Ian Oxley

11.1k6 gold badges45 silver badges49 bronze badges

2 Comments

Brad Over a year ago

There are times when you want to put that in your code to show that case 3 might be needed later, but just has the default action now. It seems like a fine and helpful pointer to me.

sberry Over a year ago

Your answer certainly isn't wrong... but I disagree. Having case 3 in there lets the person looking at the code know that there is a case 3 which, for now, should act like the default case.

Collectives™ on Stack Overflow

PHP switch() statement

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related