Python Improve Binary algorithm

Question

So in uni we learned how to multiplicate 2 binary codes. After trying in Python and getting the right result, i wanted to know if i can improve my code with less if statements or if i made any major mistakes without recognising.

l1 = [1,1,0,1,1]
l2 = [1,0,0,0,0]
brack = 0

result = []
for i in range(len(l1)):
    if l1[i] + l2[i] == 2:
        result.append(0)
        brack +=1
    elif (l1[i] + l2[i] == 1) and (brack == 0):
        result.append(1)
    elif (l1[i] + l2[i] == 1) and (brack == 1):
        result.append(0)
        brack -= 1
    elif(l1[i] + l2[i] == 0) and (brack == 1):
        result.append(0)
        brack -= 1
    elif(l1[i] + l2[i] == 0) and (brack == 0):
        result.append(0)
if (result[-1] == 0):   
    result.append(1)      
    
print(result)

Isn't this binary addition?

Vlad Rusu
– Vlad Rusu

2022-10-06 13:07:16 +00:00
Commented Oct 6, 2022 at 13:07 — Vlad Rusu
– Vlad Rusu, Commented Oct 6, 2022 at 13:07
Yes binary addition of the two lists

Wolf2k
– Wolf2k

2022-10-06 14:23:55 +00:00
Commented Oct 6, 2022 at 14:23 — Wolf2k
– Wolf2k, Commented Oct 6, 2022 at 14:23

Vlad Rusu · Accepted Answer · 2022-10-06 14:44:34Z

1

You should be able to make the bitwise addition without any ifs, but rather using modulo and division:

l1 = [1,1,0,1,1]
l2 = [1,0,0,0,0]
brack = 0

result = []
for i in range(len(l1)):
    s = l1[i] + l2[i] + brack
    result.append(s % 2)
    brack = s / 2
if (brack > 0):   
    result.append(1)      
    
print(result)

answered Oct 6, 2022 at 14:44

Vlad Rusu

1,48912 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Python Improve Binary algorithm

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related