Problem with condition statement in c#

Question

if (txt_SendAt.Text != null)
{
    //string SendAt_date = txt_Respondby.Text;
    DateTime Send_date = Convert.ToDateTime(txt_SendAt.Text);

    param[15] = new MySqlParameter("@SendDate", MySqlDbType.DateTime);
    param[15].Value = Send_date;
    command.Parameters.AddWithValue("@SendDate", Send_date);     

}
else
{
    param[15] = new MySqlParameter("@SendDate", MySqlDbType.DateTime);
    param[15].Value = now;
    command.Parameters.AddWithValue("@SendDate", now);

}

I have a text box where i select date and time from a calender. When I leave the text box empty it should execute the statements in else condition but it executes the statement in if. Where am I going wrong

I am getting this error if i leave it blank String was not recognized as a valid DateTime.

My guess is that now is a DateTime variable (probably set to DateTime.Now). Is that correct or is it a string? If a string, what's it's value? — Hans Keﬆing
– Hans Keﬆing, Commented Sep 13, 2011 at 14:59

stuartd · Accepted Answer · 2011-09-13 14:49:08Z

5

You're testing if the textbox itself is null, not it's text:

if (string.IsNullOrEmpty(txt_SendAt.Text) == false)

edited Sep 13, 2011 at 14:49

answered Sep 13, 2011 at 14:42

stuartd

73.7k16 gold badges140 silver badges172 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Polyfun Over a year ago

This should be "!string.IsNullOrEmpty(txt_SendAt.Text)" if it used in the "if" condition in the OP's code.

David Hoerster · Accepted Answer · 2011-09-13 14:42:40Z

4

Use String.IsNullOrWhitespace(txt_SendAt.Text) instead of checking for null.

You're checking if the control is null. It won't be null; you need to check if the Text property of the text box has a value. So if you use IsNullOrEmpty or IsNullOrWhitespace, you'll do a dual check -- if the control's property is null (unlikely) or if it's just blank space (or spaces).

answered Sep 13, 2011 at 14:42

David Hoerster

28.8k9 gold badges71 silver badges103 bronze badges

Comments

Tigran · Accepted Answer · 2011-09-13 14:45:17Z

2

Try:

if (!string.IsNullOrEmpty(txt_SendAt.Text))

edited Sep 13, 2011 at 14:45

Tigran

62.3k8 gold badges90 silver badges124 bronze badges

answered Sep 13, 2011 at 14:42

D'Arcy Rittich

172k41 gold badges298 silver badges287 bronze badges

1 Comment

vc 74 Over a year ago

You have to remove the condition then :)

Jodaka · Accepted Answer · 2011-09-13 14:43:16Z

1

txt_SendAt refers to the textbox control. You want txt_SendAt.Text

answered Sep 13, 2011 at 14:43

Jodaka

1,2479 silver badges16 bronze badges

Comments

Stuart Thomson · Accepted Answer · 2011-09-13 14:43:24Z

0

You should try change the if to

if ((txt_SendAt.Text != null)||(txt_SendAt.Text.Trim() != ""))

answered Sep 13, 2011 at 14:43

Stuart Thomson

5195 silver badges21 bronze badges

Collectives™ on Stack Overflow

Problem with condition statement in c#

5 Answers 5

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related