MySQL saving issue node

Question

I’m setting up a subdomain where users can upload updates to the database.

The correct data gets sent from the front end, and the API connects to the database successfully but stops there. I can’t figure out why.

app.post('/newsupdate', (req, res) => {
    let headline = req.body.headline;
    let content = req.body.content;

    let con = mysql.createConnection({
        host: HOST,
        user: USERNAME,
        password: PASSWORD,
        database: DATABASE
    });

    con.connect(function(err){
        if(err) return res.json({
            message: err
        });
  
        let sql = `INSERT INTO news (Headline, Content) VALUES (${headline}, &{content})`;
  
        con.query(sql, function(err, result){
            if(err) return res.json({message: err});

            if(result){
                res.json({
                    message: 'news update saved'
                });
            } else {
                res.json({
                    message: 'problems happened'
                });
            }
        })
    })
})

For future reference, you probably shouldn't put your real username and password into an online forum. — GROVER.
– GROVER., Commented Oct 13, 2022 at 21:28
And you should immediately change your username and password because people can see the edit history on your question. — timgavin
– timgavin, Commented Oct 13, 2022 at 21:31
Also, looking at your code, I'd suggest looking into prepared statements. — GROVER.
– GROVER., Commented Oct 13, 2022 at 21:35

lpizzinidev · Accepted Answer · 2022-10-14 06:44:24Z

1

You have a typo in your query (&{content}), try to use a prepared statement as suggested:

let sql = `INSERT INTO news (Headline, Content) VALUES (?, ?)`;

con.query(sql, [headline, content], function (err, result) {
  if (err) return res.json({ message: err });

  if (result) {
    res.json({
      message: 'news update saved',
    });
  } else {
    res.json({
      message: 'problems happened',
    });
  }
});

answered Oct 14, 2022 at 6:44

lpizzinidev

13.3k2 gold badges15 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

MixedByInstinct Over a year ago

I refactored to this and it still isn’t actually saving anything to the db, and my res.json isn’t working either. All my other routes in this api work fine though?

MixedByInstinct Over a year ago

Addendum: the con.query function is getting called, cuz it’s console.logging “saved” and shit from within the callback, it just isn’t actually functioning

lpizzinidev Over a year ago

@MixedByInstinct Can you post the result of console.log(req.body) and the structure of the news table?

MixedByInstinct Over a year ago

@Ipizzinidev on further inspection, it’s saving to the db just fine. res.json isn’t working but my original question has been answered lol. Thanks everyone 😅

MixedByInstinct Over a year ago

Final update: I was missing an e.preventDefault() call in my frontend so the page was refreshing instead of displaying the response where I wanted. It’s been a long week lol

Yonathan Rizky Nathanael · Accepted Answer · 2022-10-14 06:52:42Z

0

your syntax typo, just change to

let sql = `INSERT INTO news (Headline, Content) VALUES (${headline}, ${content})`;

answered Oct 14, 2022 at 6:52

Yonathan Rizky Nathanael

111 silver badge4 bronze badges

Collectives™ on Stack Overflow

MySQL saving issue node

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related