Why doesn't this simple if statement work?

Question

I have a simple thing I'm trying to solve.

I have a date stored in a table, and I'm comparing it to a php generated date.

ie:

if($row['start_date'] < date("Y-m-d")) {

    // table stored date larger than php date
    echo 'hi';

}  else {

    // php date larger than table stored date
    echo 'bye';

}

This seems ok to me, but

if $row['start_date'] === '2011-09-13' AND date("Y-m-d") === '2011-09-15'.

I end up with:

hi

This could be one of those twilight moments where I think left is right and a greater than symbol is actually a less than. So please help me - why doesn't this work?

in PHP are string comparable lexigraphically using <? Probably best to convert to some numeric type (unix timestamp?) and compare that instead. — Evan Teran
– Evan Teran, Commented Sep 15, 2011 at 1:47

Rolando Cruz · Accepted Answer · 2011-09-15 01:46:32Z

4

To compare dates you have to use strtotime() for $row['start_date'] and time()

if(strtotime($row['start_date']) < time())

answered Sep 15, 2011 at 1:46

Rolando Cruz

2,7841 gold badge17 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NullUserException Over a year ago

You don't "have to" use strtotime()

NullUserException · Accepted Answer · 2011-09-15 01:50:50Z

2

If $row['start_date'] = '2011-09-13' and date("Y-m-d") = '2011-09-15', then your PHP date is greater than the row's date and thus the if is true, after all '2011-09-13' is "smaller (<)" than '2011-09-15'. Flip your < to > and you'll be fine.

if($row['start_date'] > date("Y-m-d")) {

    // table stored date larger than php date
    echo 'hi';

}  else {

    // php date larger than table stored date
    echo 'bye';

}

answered Sep 15, 2011 at 1:50

NullUserException

85.8k31 gold badges212 silver badges239 bronze badges

Comments

xdazz · Accepted Answer · 2011-09-15 01:48:16Z

1

Use strtotime() to convert the string to unix timestamp then compare. Or use the DateTime object.

answered Sep 15, 2011 at 1:48

xdazz

161k38 gold badges255 silver badges278 bronze badges

Comments

Brenton Alker · Accepted Answer · 2011-09-15 01:50:34Z

0

I'm not sure on the validity of comparing dates as strings, using DateTime or strtotime and comparing timestamps may be more robust options but with this date format it should work as strings.

Other than that, your logic seems to work as written (if not as intended). "...13" is less than "...15", so the if will evaluate to true and "hi" will be printed.

Judging by the inline comments, it seems it may in fact be one of those twilight moments you speak of.

answered Sep 15, 2011 at 1:50

Brenton Alker

9,1223 gold badges38 silver badges37 bronze badges

Collectives™ on Stack Overflow

Why doesn't this simple if statement work?

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related