jQuery Optimisation Multiple Selectors

Question

At the top of my script I two variables holding two selectors:

    var all_open = $('ul#festival_dates li.controls a:eq(0)');
    var all_close = $('ul#festival_dates li.controls a:eq(1)');

I'm getting there with Jquery, I'm now at the point where I'm looking at my code and finding ways to write much more efficient scripts. One thing I noticed using YUI Compressor is that it said "[WARNING] Try to use a single 'var' statement per scope." and highlighted the two lines above, has anyone got any suggestions about this, or can explain a more technical description of what this means?

Any help would be much appreciated.

Thank you for your replie.

Joe · Accepted Answer · 2011-09-16 15:34:21Z

8

What it' saying is this:

var all_open = $('ul#festival_dates li.controls a:eq(0)'),
    all_close = $('ul#festival_dates li.controls a:eq(1)');

to use the comma operator.

As for performance, http://jsperf.com/single-var, I'm not sure it makes much of a difference.

answered Sep 16, 2011 at 15:34

Joe

82.9k18 gold badges130 silver badges147 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David Thomas · Accepted Answer · 2011-09-16 15:34:48Z

2

Instead of repeating the word var you can use commas to delimit additional variable declarations:

var all_open = $('ul#festival_dates li.controls a:eq(0)'),
all_close = $('ul#festival_dates li.controls a:eq(1)');

answered Sep 16, 2011 at 15:34

David Thomas

254k53 gold badges382 silver badges421 bronze badges

Collectives™ on Stack Overflow

jQuery Optimisation Multiple Selectors

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related